-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account details update: made email & DoB mandatory and updated onboarding texts #5
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
==========================================
- Coverage 41.07% 40.90% -0.17%
==========================================
Files 30 30
Lines 957 966 +9
==========================================
+ Hits 393 395 +2
- Misses 564 571 +7
Continue to review full report in Codecov by Sentry.
|
1. Removed Vertical Whitespace before Closing Braces 2. Solved for Trailing Newline Violation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @EvelynBunnyDev,
Thank you for the PR. It's a good first version that only needs some slight adjustments.
Your PR description does not follow the PR template that we introduced in the class, and that is provided by default: https://github.com/CS342/.github/blob/main/.github/pull_request_template.md.
Please follow the following template in your PR description and add a good description of your PR by editing the PR description on the PR page.
Great you already added a very descriptive title.
Please also read through the "Keeping your pull request in sync with the base branch" documentation to ensure that your branch is up to date with the main branch before you merge it into the main branch.
Please re-request a review once you have implemented all the requested changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just reviewed your PR again. It seems like you forgot to resolve some of the feedback I provided in my last review. Pointed them out below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Thank you, Andrea! Could you approve the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, misclicked 🙈 there you go
Name of the PR
♻️ Current situation & Problem
Modifying account detail configurations.
Responding to reviewer comment.
⚙️ Release Notes
Modified localizable strings (onboarding texts) and made the strings 'automatic'
Removed commented code that I'm not implementing.
📚 Documentation
In-line documentation provided.
✅ Testing
N/A. All elements should be testable
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: