Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing Onboarding Text and Icons #8

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Editing Onboarding Text and Icons #8

merged 3 commits into from
Jan 23, 2024

Conversation

evelyn-hur
Copy link
Contributor

@evelyn-hur evelyn-hur commented Jan 18, 2024

Editing Onboarding Text and Icons

♻️ Current situation & Problem

  • Update text and icon images on onboarding flow from Spezi Onboarding Flow template

⚙️ Release Notes

  • Edited title, description, subtitles, and icon images on Welcome page, specific to Prisma's project purpose and features.
  • Edited title, description, and subtitles on Interesting Modules page, specific to Prisma's project purpose and features.

📚 Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
N/A

✅ Testing

  • Human testing using simulator

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@PSchmiedmayer PSchmiedmayer removed their request for review January 18, 2024 06:08
@philippzagar philippzagar self-requested a review January 18, 2024 17:23
@philippzagar philippzagar added the enhancement New feature or request label Jan 18, 2024
Copy link

@philippzagar philippzagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @evelyn-hur ,

Thank you for the PR and the improvements. It's a great first version that only needs some more very minor changes!

Thank you for using the PR template! Please also add a more descriptive and clear title focusing on the added functionality rather than the assignment task. Also, fill out the Documentation part of the PR template, it's completely fine to state that you didn't do anything in that aspect within your PR.

Please also read through the "Keeping your pull request in sync with the base branch" documentation to ensure that your branch is up to date with the main branch before you merge it into the main branch.

Please re-request a review once you updated the branch to the main branch, you have updated the PR description, and addressed some of the in-line comments and I am happy to approve the PR to get it merged 🚀

Behavior/Resources/Localizable.xcstrings Show resolved Hide resolved
Behavior/Onboarding/InterestingModules.swift Outdated Show resolved Hide resolved
Behavior/Onboarding/Welcome.swift Show resolved Hide resolved
@philippzagar
Copy link

@evelyn-hur Please add your name and a proper Profile pic to your GitHub profile

@evelyn-hur evelyn-hur changed the title Tailor onboarding Editing Onboarding Text and Icons Jan 18, 2024
@evelyn-hur
Copy link
Contributor Author

Hi, thank you for your feedback! I made all changes mentioned for your review.

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7ab866e) 40.90% compared to head (fd351f1) 41.07%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
+ Coverage   40.90%   41.07%   +0.18%     
==========================================
  Files          30       30              
  Lines         961      957       -4     
==========================================
  Hits          393      393              
+ Misses        568      564       -4     
Files Coverage Δ
Behavior/Onboarding/InterestingModules.swift 0.00% <ø> (ø)
Behavior/Onboarding/Welcome.swift 94.60% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ab866e...fd351f1. Read the comment docs.

Copy link

@philippzagar philippzagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for incorporating the change requests @evelyn-hur! 🚀
PR is ready to merge!

@evelyn-hur evelyn-hur merged commit 063b54d into main Jan 23, 2024
7 checks passed
@evelyn-hur evelyn-hur deleted the tailorOnboarding branch January 23, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants