-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editing Onboarding Text and Icons #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @evelyn-hur ,
Thank you for the PR and the improvements. It's a great first version that only needs some more very minor changes!
Thank you for using the PR template! Please also add a more descriptive and clear title focusing on the added functionality rather than the assignment task. Also, fill out the Documentation
part of the PR template, it's completely fine to state that you didn't do anything in that aspect within your PR.
Please also read through the "Keeping your pull request in sync with the base branch" documentation to ensure that your branch is up to date with the main branch before you merge it into the main branch.
Please re-request a review once you updated the branch to the main branch, you have updated the PR description, and addressed some of the in-line comments and I am happy to approve the PR to get it merged 🚀
@evelyn-hur Please add your name and a proper Profile pic to your GitHub profile |
792fe55
to
b6720fb
Compare
Hi, thank you for your feedback! I made all changes mentioned for your review. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
==========================================
+ Coverage 40.90% 41.07% +0.18%
==========================================
Files 30 30
Lines 961 957 -4
==========================================
Hits 393 393
+ Misses 568 564 -4
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for incorporating the change requests @evelyn-hur! 🚀
PR is ready to merge!
6be79bb
to
fd351f1
Compare
Editing Onboarding Text and Icons
♻️ Current situation & Problem
⚙️ Release Notes
📚 Documentation
Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
N/A
✅ Testing
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: