Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax in example #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

martbhell
Copy link
Contributor

No description provided.

Copy link
Collaborator

@VilleS1 VilleS1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both "pubkey:" and "pubkeys:" formats are supported. The "pubkeys:" format is documented on line 40. I kind of agree that it's confusing to have two different ways, but the current documentation is correct, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally still valid! Just not fun to add all the brackets and curlies to convert from string to list.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably my eyes that are not as good as they used to. I think the proposed change of documenting multiple keys is already documented on line 40? So copy pasting should work as it has the pubkeys in a list?

Honestly I don't really mind either way, and I can merge this too, I was just wondering if there is something I'm missing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants