Skip to content

Commit

Permalink
Longer context
Browse files Browse the repository at this point in the history
  • Loading branch information
Nortamo committed Sep 19, 2024
1 parent 0d9cea8 commit d68fd47
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion configs/mahti.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ defaults:
composable: true
# if this is not a thing which exist
# I will do a singularity pull
container_src: 'docker://redhat/ubi8:8.6'
container_src: 'docker://redhat/ubi8:8.10'
# name of the container image when on disk
container_image: container.sif
sqfs_image: img.sqfs
Expand Down
4 changes: 2 additions & 2 deletions templates/conda.sh
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ curl https://repo.anaconda.com/miniconda/Miniconda3-$CW_CONDA_VERSION-$CW_CONDA_
print_info "Installing miniconda " 1
bash Miniconda_inst.sh -b -p $CW_INSTALLATION_PATH/miniconda > $CW_BUILD_TMPDIR/_inst_miniconda.log &
inst_pid=$!
follow_log $inst_pid $CW_BUILD_TMPDIR/_inst_miniconda.log 10
follow_log $inst_pid $CW_BUILD_TMPDIR/_inst_miniconda.log 20
rm Miniconda_inst.sh
eval "$($CW_INSTALLATION_PATH/miniconda/bin/conda shell.bash hook)"
cd $CW_WORKDIR
Expand All @@ -39,7 +39,7 @@ else
fi

inst_pid=$!
follow_log $inst_pid $CW_BUILD_TMPDIR/build.log 10
follow_log $inst_pid $CW_BUILD_TMPDIR/build.log 20
wait $inst_pid
conda activate $CW_ENV_NAME
if [[ ${CW_REQUIREMENTS_FILE+defined} ]];then
Expand Down
2 changes: 1 addition & 1 deletion templates/conda_modify.sh
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ if [[ ${CW_REQUIREMENTS_FILE+defined} ]];then
pip install -r $( basename "$CW_REQUIREMENTS_FILE" ) > $CW_BUILD_TMPDIR/_pip.log &
bg_pid=$!
wait $bg_pid
follow_log $bg_pid $CW_BUILD_TMPDIR/_pip.log 10
follow_log $bg_pid $CW_BUILD_TMPDIR/_pip.log 20
fi
cd $CW_WORKDIR
source $CW_INSTALLATION_PATH/_post_install.sh
Expand Down
2 changes: 1 addition & 1 deletion templates/venv.sh
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ if [[ ${CW_REQUIREMENTS_FILE+defined} ]];then
pip install --disable-pip-version-check -r "$( basename $CW_REQUIREMENTS_FILE)" > $CW_BUILD_TMPDIR/_pip.log &
bg_pid=$!
wait $bg_pid
follow_log $bg_pid $CW_BUILD_TMPDIR/_pip.log 10
follow_log $bg_pid $CW_BUILD_TMPDIR/_pip.log 20
fi
cd $CW_WORKDIR
print_info "Running user supplied commands" 1
Expand Down
2 changes: 1 addition & 1 deletion templates/venv_modify.sh
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ if [[ ${CW_REQUIREMENTS_FILE+defined} ]];then
pip install --disable-pip-version-check -r "$( basename $CW_REQUIREMENTS_FILE)" > $CW_BUILD_TMPDIR/_pip.log &
bg_pid=$!
wait $bg_pid
follow_log $bg_pid $CW_BUILD_TMPDIR/_pip.log 10
follow_log $bg_pid $CW_BUILD_TMPDIR/_pip.log 20
fi
cd $CW_WORKDIR
#print_info "Running user supplied commands" 1
Expand Down
2 changes: 1 addition & 1 deletion tests/tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ dependencies:
" > conda_broken.yaml
echo "GARBAGE" > conda_env.txt

t_run "conda-containerize new conda_base.yml --prefix NOT_A_DIR | grep ERROR" "Missing install dir causes error"
t_run "conda-containerize new conda_base.yml --prefix NOT_A_DIR" "Missing install dir is created"
mkdir A_DIR_NO_WRITE
chmod ugo-w A_DIR_NO_WRITE
t_run "conda-containerize new conda_base.yml --prefix A_DIR_NO_WRITE | grep ERROR" "Installation dir has to be writable"
Expand Down

0 comments on commit d68fd47

Please sign in to comment.