-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LoopIdiom] Set no_preserve_cheri_tags when possible #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arichardson
force-pushed
the
no-preserve-tags-nfc-prep
branch
from
March 22, 2022 21:30
f307169
to
20dfcd2
Compare
arichardson
force-pushed
the
no-preserve-tags-nfc-prep
branch
3 times, most recently
from
April 25, 2022 16:03
50aa1b8
to
bf88828
Compare
arichardson
force-pushed
the
no-preserve-tags-nfc-prep
branch
from
July 6, 2022 07:37
bf88828
to
eab5c92
Compare
arichardson
force-pushed
the
no-preserve-tags-nfc-prep
branch
from
August 4, 2022 21:47
eab5c92
to
5308fac
Compare
arichardson
force-pushed
the
no-preserve-tags-nfc-prep
branch
from
August 15, 2022 08:35
5308fac
to
017786a
Compare
arichardson
force-pushed
the
no-preserve-tags-loopidiom
branch
from
August 15, 2022 08:41
7926a3e
to
31340d0
Compare
rebased. |
arichardson
force-pushed
the
no-preserve-tags-nfc-prep
branch
from
August 16, 2022 09:50
017786a
to
c169ab1
Compare
arichardson
force-pushed
the
no-preserve-tags-loopidiom
branch
from
October 11, 2023 23:23
31340d0
to
697bf7f
Compare
rebased to LLVM 15 |
arichardson
force-pushed
the
no-preserve-tags-loopidiom
branch
from
November 10, 2023 17:20
697bf7f
to
5531781
Compare
ping. |
arichardson
commented
Nov 13, 2023
ping? |
arichardson
force-pushed
the
no-preserve-tags-loopidiom
branch
from
February 6, 2024 20:09
5531781
to
997d61a
Compare
This allows inlining of underaligned memcpy() calls that copy more than capability size (which will be most of the ones created by this pass). Previously, we weren't setting any attribute on the memcpy at all which meant that the backends had to be conservative when inlining the memcpy.
arichardson
force-pushed
the
no-preserve-tags-loopidiom
branch
from
February 6, 2024 21:21
997d61a
to
9bba204
Compare
arichardson
commented
Feb 6, 2024
@jrtc27 since this is a pretty simple change I'm going to merge this by end of week unless you have any comments. |
jrtc27
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems sensible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows inlining of underaligned memcpy() calls that copy more than
capability size (which will be most of the ones created by this pass).
Previously, we weren't setting any attribute on the memcpy at all which
meant that the backends had to be conservative when inlining the memcpy.