Prefer capability types when lowering unions to LLVM IR types #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrtc27
reviewed
Feb 6, 2024
Unions that contain an int128 and a capability are passed as a single i128 instead of as a capability or indirectly.
This ensures that a union contain a __int128 and a capability will be lowered as a struct with one capability field instead of as an i128. This fixes tag stripping when passing such unions to functions by value instead of by reference.
arichardson
force-pushed
the
capability-union-types
branch
from
451cfe0
to
e80c5f5
Compare
|
I believe I've addressed all comments, will merge on Monday unless there are further comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that a union containing a __int128 and a capability will
be lowered as a struct with one capability field instead of as an
i128. This fixes tag stripping when passing such unions to functions
by value instead of by reference.