Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update course_guide_learners_static.md #13

Closed
wants to merge 1 commit into from
Closed

Update course_guide_learners_static.md #13

wants to merge 1 commit into from

Conversation

abnerbog
Copy link
Collaborator

Fixes #2. Copied contents of the individual issue markdowns and removed/modified actions related to issue opening/closing/commenting.

Copied contents of the individual issue markdowns and removed/modified actions related to issue opening/closing/commenting.
Copy link
Collaborator

@lindsayplatt lindsayplatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review, now we are chatting!

@@ -1,486 +1,569 @@
<details>
<summary><h2>How to start working on a new project</h2></summary>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still want all the issue names to appear as collapsible headers just like the previous version had to help keep things organized.

Here is an example of that.

<details>
<summary><h2>The section name</h2></summary>
 THE CONTENT
</details>

Will create this:

The section name

THE CONTENT

Comment on lines +39 to +42
----------------------------------------------------------------------------------------------------------------
**Action:** Close this issue after you read about the workflow and proceed to the next issue in sequential
order.
----------------------------------------------------------------------------------------------------------------
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We no longer need this action :)

Suggested change
----------------------------------------------------------------------------------------------------------------
**Action:** Close this issue after you read about the workflow and proceed to the next issue in sequential
order.
----------------------------------------------------------------------------------------------------------------

@@ -1,486 +1,569 @@
<details>
<summary><h2>How to start working on a new project</h2></summary>
Scenario: You are pointed to a code repository on GitHub (this one) for
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An example of how to start a collapsible section.

Suggested change
Scenario: You are pointed to a code repository on GitHub (this one) for
<details>
<summary><h2>How to start working on a new project</h2></summary>
Scenario: You are pointed to a code repository on GitHub (this one) for

We are going to walk through each of these steps within the workflow in
this lesson. We will also learn about merge conflicts and what a
`.gitignore` file is all about.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An example of how to close out a collapsible section.

Suggested change
</details>

`remote` because it is online.

-------------------------------------------------------------------------------------------------
**Action:** Link your cloned repository to the upstream remote.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a whole section missing here? There should be 7 steps right after this

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the beginning of the next section is missing?

@abnerbog abnerbog closed this by deleting the head repository May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic --> Static (migrate issue content into a new "course_instructions.md")
2 participants