Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VASSAL: Add VASSAL engine v3.7.14 #1250

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

finsterdexter
Copy link
Contributor

@finsterdexter finsterdexter commented Oct 19, 2024

Adding manifest for VASSAL. This closes #960

Copy link
Contributor

Your changes do not pass checks.

vassal

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

vassal

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@finsterdexter
Copy link
Contributor Author

I added installer and uninstaller properties in the manifest. When I test this it does pop up the UAC prompt since even running silently and setting destination to scoop $dir doesn't cause the installer to not try and elevate to admin. Is that an issue, as I think the goal with scoop manifests is to avoid UAC, but I'm not sure of the best way to avoid that here.

@Calinou
Copy link
Owner

Calinou commented Oct 24, 2024

Is that an issue, as I think the goal with scoop manifests is to avoid UAC, but I'm not sure of the best way to avoid that here.

This is a NSIS-based installer according to file:

$ file VASSAL-3.7.14-windows-x86_64.exe
VASSAL-3.7.14-windows-x86_64.exe: PE32 executable (GUI) Intel 80386 (stripped to external PDB), for MS Windows, Nullsoft Installer self-extracting archive, 7 sections

You should be able to remove the (un)installer properties and add #/dl.7z at the end of the download URL, similar to sauerbraten.json. This will make Scoop extract the installer using 7-zip, so that the installer doesn't even need to be run.

@Calinou Calinou added the new package A package should be added label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new package A package should be added review-needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request]: Vassal engine
2 participants