Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn Porffor.rawType into a macro #116

Closed
wants to merge 12 commits into from

Conversation

BobVarioa
Copy link
Contributor

Should theoretically make Porffor.rawType a bit faster, and eventually allows for more optimizations. Also introduces --warn-assumed-type from #56 which was useful for debugging this feature.

compiler/codegen.js Outdated Show resolved Hide resolved
compiler/codegen.js Outdated Show resolved Hide resolved
@BobVarioa BobVarioa requested a review from CanadaHonk July 6, 2024 15:14
compiler/codegen.js Outdated Show resolved Hide resolved
Copy link
Owner

@CanadaHonk CanadaHonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, ty! Could you fix the merge conflict? 😅

@BobVarioa
Copy link
Contributor Author

Looks good now, ty! Could you fix the merge conflict? 😅

Alright, should be ready now!

@CanadaHonk
Copy link
Owner

CanadaHonk commented Jul 9, 2024

Merging manually because GH merging is useless 🔥

@CanadaHonk
Copy link
Owner

Merged in:

@CanadaHonk CanadaHonk closed this Jul 9, 2024
@BobVarioa BobVarioa deleted the rawtype-opt branch July 13, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants