test(clickhouse): test all functions #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldmedal
reviewed
Nov 27, 2024
| window,lastValue,Same as input,"Returns last value in window frame." | ||
| window,nthValue,Same as input,"Returns nth value in window frame." | ||
| function_type,name,return_type,param_names,param_types,description | ||
| aggregate,min,Same as input,,Any,"Returns the minimum value." |
There was a problem hiding this comment.
Suggested change
| aggregate,min,Same as input,,Any,"Returns the minimum value." | |
| aggregate,min,Same as input,,Any,"Returns the minimum value." |
The return type is weird 🤔. I think they're duplicated with the datafusion default functions. Maybe we can just remove them.
goldmedal
reviewed
Nov 27, 2024
Comment on lines
4
to
6
| scalar,round,Same as input,,Float64, "Rounds number to specified decimal places." | ||
| scalar,floor,Same as input,,Numeric,"Rounds down to nearest integer." | ||
| scalar,ceil,Same as input,,Numeric,"Rounds up to nearest integer." |
There was a problem hiding this comment.
Same issue. The return types aren't valid.
goldmedal
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added a test case and moved out some functions that need to be revised.
#951