feat: populate span links #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taj-p
force-pushed
the
tajp-populateSpanLinks
branch
from
93ea6f5 to
5cd35b3
Compare
taj-p
commented
Mar 9, 2023
Signed-off-by: Taj Pereira <[email protected]>
taj-p
commented
Mar 9, 2023
Signed-off-by: Taj Pereira <[email protected]>
tin1337
force-pushed
the
tajp-populateSpanLinks
branch
from
36fd937 to
c54d383
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
Populate the
span.referencesmember appropriately so that we see the below:Instead of this (which provides 0 contextualisation 🤮 )
Why not do this in Jaeger Query?
Doing this in Jaeger Query requires us to update a data model used across its codebase. This is simpler, more targeted, and we expect to re-investigate how to visualise these traces once we decide on a more permanent trace visualisation option (i.e. this will only be used in the short term presumably).
Note that this will send a trace query for each link in a trace. Since we don't use span links commonly, this is a presumed insignificant cost.
What happens if the linked span hasn't yet arrived in storage?
It reverts to the non-contextualised version.