New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use entrypoint script in `[name].runfiles/` symlink forest by default #10

Merged

Silic0nS0ldier merged 1 commit into main from jordan-mele_entrypoint-in-runfiles-forest

Nov 15, 2023

Contributor

Silic0nS0ldier commented Nov 15, 2023

Makes nodejs_binary and nodejs_test require --enable_runfiles to be enabled.

This change makes the resolved file path more consistent, and is a requirement for the refactored node_modules linker to come in a future PR.


          Use entrypoint script in [name].runfiles/ symlink forest by default

8944f15

Silic0nS0ldier requested review from christianscott and jesses-canva as code owners

November 15, 2023 00:47

christianscott approved these changes

View reviewed changes

Silic0nS0ldier merged commit d9c2214 into main

1 check passed

Silic0nS0ldier deleted the jordan-mele_entrypoint-in-runfiles-forest branch

December 6, 2023 23:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet