Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support proxy env vars #13

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Support proxy env vars #13

merged 2 commits into from
Nov 15, 2023

Conversation

Silic0nS0ldier
Copy link
Contributor

Adds proxying support via;

  • HTTP_PROXY
  • HTTPS_PROXY
  • NO_PROXY
  • ALL_PROXY

christianscott
christianscott approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@christianscott christianscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Silic0nS0ldier Silic0nS0ldier merged commit 9fbdb22 into main Nov 15, 2023
1 check passed
@Silic0nS0ldier Silic0nS0ldier deleted the jordan-mele_nm-install-proxy-env branch December 6, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianscott christianscott christianscott approved these changes

@jesses-canva jesses-canva Awaiting requested review from jesses-canva

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Silic0nS0ldier @christianscott