Actually stop the terminal opening when rendering on Windows

CapSoftware · Nov 15, 2024 · 8df1667 · 8df1667
1 parent 0c6ce3f
commit 8df1667
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/crates/ffmpeg-cli/src/lib.rs b/crates/ffmpeg-cli/src/lib.rs
@@ -14,6 +14,13 @@ pub struct FFmpegProcess {
 
 impl FFmpegProcess {
     pub fn spawn(mut command: Command) -> Self {
+        #[cfg(target_os = "windows")]
+        {
+            use std::os::windows::process::CommandExt;
+            const CREATE_NO_WINDOW: u32 = 0x08000000;
+            command.creation_flags(CREATE_NO_WINDOW);
+        }
+
         let mut cmd = command.stdin(Stdio::piped()).spawn().unwrap_or_else(|e| {
             println!("Failed to start FFmpeg: {}", e);
             println!("Command: {:?}", command);

diff --git a/crates/rendering/src/main.rs b/crates/rendering/src/main.rs
@@ -1,5 +1,3 @@
-// Prevents additional console window on Windows in release, DO NOT REMOVE!!
-#![cfg_attr(not(debug_assertions), windows_subsystem = "windows")]
 // use cap_project::{BackgroundSource, ProjectConfiguration, RecordingMeta};
 
 #[tokio::main]