Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cap for Windows, Part 2 #163

Merged
merged 34 commits into from
Nov 13, 2024
Merged

Cap for Windows, Part 2 #163

merged 34 commits into from
Nov 13, 2024

Conversation

ItsEeleeya
Copy link
Contributor

@ItsEeleeya ItsEeleeya commented Nov 12, 2024

Windows:

  • Adds native-looking titlebars for Windows.
  • Fixes window_names() and monitor_bounds().

macOS

  • Transparent background for the scrollbar on the prev-recordings window (For Windows)
  • Use invalidateShadow function to make sure newly created windows have a shadow on macOS.

Known Issue:
Currently does not compile on Windows.
scap needs to implement the correct way for getting raw frames on Windows. Or the usage in Cap will need to be platform dependent.
Changes on scap (4d6be03) are not yet implemented for Windows.

  • display Screen when there's only one screen available.
  • windows pipes for cap::render_to_file_imp

Copy link

vercel bot commented Nov 12, 2024

@ItsEeleeya is attempting to deploy a commit to the Cap Software Inc Team on Vercel.

A member of the Team first needs to authorize it.

@Brendonovich
Copy link
Member

Raw capture is macos only atm, I've reverted AVFrameCapture to use get_next_frame since I forgot to earlier

@Brendonovich Brendonovich marked this pull request as ready for review November 13, 2024 10:07
@Brendonovich Brendonovich changed the title (WIP) Cap for Windows, Part 2 Cap for Windows, Part 2 Nov 13, 2024
@Brendonovich
Copy link
Member

Core features have been implemented now, any problems should be filed as issues with the 'windows' label.

@Brendonovich Brendonovich merged commit 5ded4dd into CapSoftware:main Nov 13, 2024
2 of 5 checks passed
@ItsEeleeya ItsEeleeya deleted the windows branch November 13, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants