StaticAbilityAssignNoCombatDamage: Static and first batch #5998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It might be interesting to check that it's not worse for performance on average case? |
|
@tool4ever the difference is the rules ... technically hidden keywords shouldn't exist, and they cause more problems that it is worth The main issue is StaticAbilityContinuous + HiddenKeywords because these are updated each time the Layers are updated. See #3307 for more issues |
|
@tool4ever i updated the remaining cards |
tool4ever
approved these changes
Aug 28, 2024
Northmoc
pushed a commit
to Northmoc/forge
that referenced
this pull request
Nov 22, 2024
* StaticAbilityAssignNoCombatDamage --------- Co-authored-by: tool4ever <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5992
Static Ability and first batch of cards, others will be added later to this MR