Support engine tracking card mover vs. controller #6420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tool4ever
added
Game Mechanics
Rules compliance
Hanmac
reviewed
Oct 24, 2024
| // Don't copy Tokens, copy only cards leaving the battlefield | ||
| // and returning to hand (to recreate their spell ability information) | ||
| if (toBattlefield || (suppress && zoneTo.getZoneType().isHidden())) { | ||
| copied = c; | ||
|
|
||
| // in some cases it's always affected that puts them in play (initially) | ||
| String defPutter; | ||
| if (cause == null || (!cause.hasParam("Putter") && (c.isToken() || |
There was a problem hiding this comment.
I don't know if I like it there
I probably would move the Putter logic into AbilityKey.addCardZoneTableParams
There was a problem hiding this comment.
hmn, the problem is the Putter can be different players during the same effect
and most effects currently don't need to modify moveParams between cards and reuse them instead
so I'd have to refactor those further, especially when they pass down to helpers in SpellAbilityEffect like with discard?
There was a problem hiding this comment.
imo it would be more clean if the stuff is done in the specific SpellAbilityEffect classes (or a helper function)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support that will be needed for #5137