Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CreatureEvaluator.java #6445

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update CreatureEvaluator.java #6445

wants to merge 2 commits into from

Commits on Oct 27, 2024

  1. Update CreatureEvaluator.java 

    Break down the evaluation logic into smaller methods.
Add comments to explain the purpose of each section.
Add logging for debugging purposes.
Implement a method to print the evaluation details for better insight.
    @Yash-2707
    Yash-2707 authored Oct 27, 2024
    Configuration menu
    Copy the full SHA
    8bd14a0 View commit details
    Browse the repository at this point in the history

  2. Update CreatureEvaluator.java 

    Retained Unaddressed TODO Comment:
Fixed the incorrect addition logic for the vanishing keyword to ensure it subtracts value correctly
Corrected the section where the reset logic for useless cards was broken due to splitting
Removed comments that only spell out the function name again, as they don't add additional information
    @Yash-2707
    Yash-2707 authored Oct 27, 2024
    Configuration menu
    Copy the full SHA
    92380de View commit details
    Browse the repository at this point in the history