Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A0-3022: Abft Score Metrics #1898

Merged
merged 7 commits into from
Dec 23, 2024
Merged

A0-3022: Abft Score Metrics #1898

merged 7 commits into from
Dec 23, 2024

Conversation

mike1729
Copy link
Member

No description provided.

@mike1729 mike1729 enabled auto-merge December 21, 2024 11:22
@mike1729 mike1729 force-pushed the 3022 branch 3 times, most recently from 248851e to 5e5aee7 Compare December 23, 2024 10:50
timorleph
timorleph approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@timorleph timorleph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, some minor comments.

bin/chain-bootstrapper/src/chain_spec/cli.rs Outdated Show resolved Hide resolved
finality-aleph/src/abft/current/performance/service.rs Show resolved Hide resolved
finality-aleph/src/party/manager/mod.rs Outdated Show resolved Hide resolved
pallets/aleph/src/lib.rs Outdated Show resolved Hide resolved
scripts/run_nodes.sh Show resolved Hide resolved
timorleph
timorleph approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@timorleph timorleph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more tiny nitpick.

finality-aleph/src/party/mod.rs Outdated Show resolved Hide resolved
@mike1729 mike1729 added this pull request to the merge queue Dec 23, 2024
Merged via the queue into main with commit 0e6fa63 Dec 23, 2024
15 checks passed
@mike1729 mike1729 deleted the 3022 branch December 23, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timorleph timorleph timorleph approved these changes

@Marcin-Radecki Marcin-Radecki Marcin-Radecki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mike1729 @Marcin-Radecki @timorleph