Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drink integration #43

Merged
merged 26 commits into from
Feb 16, 2024
Merged

Drink integration #43

merged 26 commits into from
Feb 16, 2024

Conversation

kroist
Copy link
Contributor

@kroist kroist commented Jan 30, 2024

add integration tests with drink

Copy link
Contributor

@Yithis Yithis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only added two small nits

@kroist kroist force-pushed the drink_integration branch 2 times, most recently from 35bbd8a to 6e22ae9 Compare February 13, 2024 00:07
@kroist
Copy link
Contributor Author

kroist commented Feb 13, 2024

appended legacy-shielder to old github action names. Requesting to rename them in branch protection rules

Copy link
Contributor

@Yithis Yithis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any notes other than those already mentioned by @pmikolajczyk41. Approved, since you will have to get his approve anyway

@kroist kroist merged commit 726d8e8 into main Feb 16, 2024
1 check passed
@kroist kroist deleted the drink_integration branch February 16, 2024 09:51
Yithis pushed a commit that referenced this pull request Feb 16, 2024
Yithis pushed a commit that referenced this pull request Feb 19, 2024
Yithis pushed a commit that referenced this pull request Feb 19, 2024
Yithis pushed a commit that referenced this pull request Feb 19, 2024
Yithis pushed a commit that referenced this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants