-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drink integration #43
Conversation
63c8e0b
to
9b1e4b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, only added two small nits
35bbd8a
to
6e22ae9
Compare
appended |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have any notes other than those already mentioned by @pmikolajczyk41. Approved, since you will have to get his approve anyway
fbb06df
to
0ac348c
Compare
0ac348c
to
c241d5e
Compare
add integration tests with drink