Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A0-3777: Add fundamental relations #44

Merged
merged 16 commits into from
Feb 19, 2024
Merged

A0-3777: Add fundamental relations #44

merged 16 commits into from
Feb 19, 2024

Conversation

Yithis
Copy link
Contributor

@Yithis Yithis commented Feb 13, 2024

No description provided.

DamianStraszak
DamianStraszak reviewed Feb 14, 2024
View reviewed changes
relations/src/lib.rs Show resolved Hide resolved
relations/src/note.rs Outdated Show resolved Hide resolved
relations/Cargo.toml Outdated Show resolved Hide resolved
relations/src/proof.rs Outdated Show resolved Hide resolved
relations/src/proof.rs Outdated Show resolved Hide resolved
relations/src/proof.rs Outdated Show resolved Hide resolved
relations/src/proof.rs Outdated Show resolved Hide resolved
pmikolajczyk41
pmikolajczyk41 reviewed Feb 15, 2024
View reviewed changes
rust-toolchain.toml Outdated Show resolved Hide resolved
relations/Cargo.toml Show resolved Hide resolved
relations/src/hasher.rs Outdated Show resolved Hide resolved
relations/src/hasher.rs Outdated Show resolved Hide resolved
relations/src/hasher.rs Outdated Show resolved Hide resolved
relations/src/proof.rs Outdated Show resolved Hide resolved
DamianStraszak
DamianStraszak requested changes Feb 16, 2024
View reviewed changes
relations/src/merkle_proof.rs Outdated Show resolved Hide resolved
relations/src/merkle_proof.rs Outdated Show resolved Hide resolved
relations/src/merkle_proof.rs Outdated Show resolved Hide resolved
relations/src/note.rs Outdated Show resolved Hide resolved
relations/src/relations/update_account.rs Outdated Show resolved Hide resolved
relations/src/relations/update_note.rs Outdated Show resolved Hide resolved
DamianStraszak
DamianStraszak approved these changes Feb 16, 2024
View reviewed changes
relations/src/relations/update_note.rs Outdated Show resolved Hide resolved
relations/src/merkle_proof.rs Outdated Show resolved Hide resolved
pmikolajczyk41
pmikolajczyk41 approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@pmikolajczyk41 pmikolajczyk41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left few comments, none of them is severe (I'm guessing that only Op -> OpPub arg type is important)

I know that this one blocks some other work, so approval from me - please resolve comments at your will

relations/Cargo.toml Outdated Show resolved Hide resolved
relations/src/account.rs Outdated Show resolved Hide resolved
relations/src/operation.rs Outdated Show resolved Hide resolved
relations/src/note.rs Outdated Show resolved Hide resolved
relations/src/merkle_proof.rs Outdated Show resolved Hide resolved
relations/src/relations/update_account.rs Show resolved Hide resolved
relations/src/relations/update_account.rs Show resolved Hide resolved
relations/src/account.rs Outdated Show resolved Hide resolved
@Yithis Yithis merged commit 13ae225 into main Feb 19, 2024
1 check passed
@Yithis Yithis deleted the a0-3777-relations branch February 19, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DamianStraszak DamianStraszak DamianStraszak approved these changes

@pmikolajczyk41 pmikolajczyk41 pmikolajczyk41 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yithis @DamianStraszak @pmikolajczyk41 @kroist