Relayer fees #51
Open
Relayer fees #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmikolajczyk41
requested changes
Mar 27, 2024
Comment on lines
-41
to
+35
| setup-tests: build-psp22 build-shielder ## Builds contracts and generates wrappers. | ||
| setup-tests: build-shielder ## Builds contracts and generates wrappers. |
There was a problem hiding this comment.
nit: things like removing psp submodule can be easily done in separate mini PRs
Comment on lines
+123
to
+138
| build_call::<DefaultEnvironment>() | ||
| .call(AccountId::from(token.bytes)) | ||
| .call_v1() | ||
| .gas_limit(0) | ||
| .transferred_value(0) | ||
| .exec_input( | ||
| ExecutionInput::new(Selector::new(ink::selector_bytes!( | ||
| "PSP22::transfer_from" | ||
| ))) | ||
| .push_arg(AccountId::from(user.bytes)) | ||
| .push_arg(self.env().account_id()) | ||
| .push_arg(amount) | ||
| .push_arg([].to_vec() as ink::prelude::vec::Vec<u8>), | ||
| ) | ||
| .returns::<Result<(), PSP22Error>>() | ||
| .invoke()?; |
There was a problem hiding this comment.
please reduce repetitions across this module - you can crate functions dedicated for transfer and transfer_from that would hide the whole boilerplate
| @@ -26,3 +26,9 @@ pub fn init_bob(session: &mut Session<MinimalSandbox>) -> Result<AccountId32> { | |||
| init_acc_with_balance(session, &res)?; | |||
| Ok(res) | |||
| } | |||
|
|
|||
| pub fn init_relayer(session: &mut Session<MinimalSandbox>) -> Result<AccountId32> { | |||
| let res = AccountId32::new([4u8; 32]); | |||
There was a problem hiding this comment.
please use constants for all actors in this module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduced relayer logic by adding two public operations:
DepositRelayer,WithdrawRelayerboth operations mirror
DepositandRelayerrespectively, but with three additional fields:fee: u128- amount of fee for relayerfee_token: Scalar- fee payment tokenrelayer: Scalar- relayer address