Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
check if _gat exists before including ga.js
This is supposed to allow users to use dc.js with gas. They should include the dc.js file synchronously before the _gas code snippet.
- Loading branch information
077da0c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
o/ \o
Much more elegant solution!
077da0c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you might want to add ashx as file format for download as MS often wraps for example pdf in ashx etc
077da0c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we found the vimeo tracking to work better than others.
if you get time perhaps outline what code we could extract from the gas file to just make this vimeo tracking
the vimeo code itself that you have made, but perhaps also soom hooks and listeners?
anyway otherwise i will have a look but if you have any helpful input it is welcome