Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddPeople DeletePeople #46

Merged
merged 7 commits into from
Dec 15, 2023
Merged

Conversation

sopa301
Copy link
Collaborator

@sopa301 sopa301 commented Dec 15, 2023

No description provided.

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 335 lines in your changes are missing coverage. Please review.

Comparison is base (10a2fb3) 6.20% compared to head (65eaa5f) 5.72%.

Files Patch % Lines
src/models/Project.ts 4.22% 136 Missing ⚠️
src/commands/editProject/deletePeopleScene.ts 0.00% 70 Missing and 1 partial ⚠️
src/commands/editProject/addPeopleScene.ts 0.00% 69 Missing and 1 partial ⚠️
src/db/functions.ts 31.42% 24 Missing ⚠️
src/commands/addProjectScene.ts 0.00% 7 Missing ⚠️
src/commands/editProject/editProjectScene.ts 0.00% 7 Missing ⚠️
...ommands/editProject/editProjectDescriptionScene.ts 0.00% 4 Missing ⚠️
src/commands/editProject/editProjectNameScene.ts 0.00% 4 Missing ⚠️
src/index.ts 0.00% 4 Missing ⚠️
src/util/userInput.ts 0.00% 3 Missing and 1 partial ⚠️
... and 2 more
Additional details and impacted files
@@           Coverage Diff            @@
##            main     #46      +/-   ##
========================================
- Coverage   6.20%   5.72%   -0.48%     
========================================
  Files         33      36       +3     
  Lines       1644    1921     +277     
  Branches      38      41       +3     
========================================
+ Hits         102     110       +8     
- Misses      1512    1778     +266     
- Partials      30      33       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sopa301 sopa301 marked this pull request as ready for review December 15, 2023 17:48
@sopa301 sopa301 added this to the v0.2 milestone Dec 15, 2023
Copy link
Collaborator

@nikele2001 nikele2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikele2001 nikele2001 merged commit 66ea124 into CarelessLlama:main Dec 15, 2023
3 of 5 checks passed
@sopa301 sopa301 deleted the branch-slap branch December 15, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do input validation for Project class Implement Delete People Feature Implement Add People feature
2 participants