Add input validation #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
========================================
- Coverage 5.72% 5.58% -0.14%
========================================
Files 36 36
Lines 1921 1968 +47
Branches 41 41
========================================
Hits 110 110
- Misses 1778 1825 +47
Partials 33 33 ☔ View full report in Codecov by Sentry. |
Apply SLAP to addProjectScene and viewMainMenuScene
sopa301
approved these changes
Dec 16, 2023
| 'Please enter a valid project name. A project name needs to be at least 3 characters long and cannot start with /.', | ||
| ); | ||
| } | ||
| const text = getTextFromTextMessages(ctx); |
There was a problem hiding this comment.
I like this refactor. I would do it the same way too.
| * @param text - The text to check | ||
|
|
||
| */ | ||
| export const validateProjectName = (text: string) => { |
There was a problem hiding this comment.
I believe the Project class already has this method
| * Checks if a string is a valid project description. | ||
| * @param text - The text to check | ||
| */ | ||
| export const validateProjectDescription = (text: string) => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.