Feat/add status transfer 2 #136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tensojka
requested changes
Sep 19, 2024
Oleh-Zorin
changed the title
tensojka
requested changes
Sep 20, 2024
There was a problem hiding this comment.
Functionally, it works, but there are a few code quality issues that should be fixed before merging.
I fixed the data.length > 0 bug, but its existence makes me ask: was this tested? Do you have a wallet, some KONOHA tokens, guardianship, did you try to cancel a transfer?
I'm not thrilled about the status not being a table but instead a custom third thing that looks like a table, and yet it looks different from the Your Stakes table. But I guess we'll have to live with it.
| return ( | ||
| <div key={index} className="flex flex-wrap flex-row"> | ||
| <div className='flex flex-wrap flex-row w-full'> | ||
| <div className="flex-1 w-1/2 basis-1/2 p-2 bg-slate-200 text-left text-gray-700 uppercase tracking-wider border-r border-slate-400">token</div> |
There was a problem hiding this comment.
What is the reasoning behind the border-r here?
|
|
||
|
|
||
| useEffect(() => { | ||
| refetch() |
There was a problem hiding this comment.
What is the purpose of this chunk of code?
tensojka
reviewed
Sep 20, 2024
tensojka
reviewed
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.