Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish Treasury – add more tests #85

Merged
merged 2 commits into from
May 23, 2024
Merged

Finish Treasury – add more tests #85

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d10d66
Add more treasury tests
tensojka May 23, 2024
6f19243
Format
tensojka May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
114 changes: 107 additions & 7 deletions tests/test_treasury.cairo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ mod testStorage {
const zero_address: felt252 = 0;
const GOV_CONTRACT_ADDRESS: felt252 =
0x0304256e5fade73a6fc8f49ed7c1c43ac34e6867426601b01204e1f7ba05b53d;
const AMM_CONTRACT_ADDRESS: felt252 =
0x018890b58b08f341acd1292e8f67edfb01f539c835ef4a2176946a995fe794a5;
const CARMINE_AMM_CONTRACT_ADDRESS: felt252 =
0x047472e6755afc57ada9550b6a3ac93129cc4b5f98f51c73e0644d129fd208d9;
}

use core::result::ResultTrait;
Expand All @@ -15,24 +15,23 @@ use core::traits::{TryInto, Into};
use core::byte_array::ByteArray;
use array::ArrayTrait;
use debug::PrintTrait;
use starknet::ContractAddress;
use starknet::{ContractAddress, get_block_number, ClassHash};
use snforge_std::{
BlockId, declare, ContractClassTrait, ContractClass, prank, CheatSpan, CheatTarget, start_roll,
stop_roll,
BlockId, declare, ContractClassTrait, ContractClass, prank, CheatSpan, CheatTarget, roll
};
use konoha::treasury::{ITreasuryDispatcher, ITreasuryDispatcherTrait};
use konoha::treasury_types::carmine::{IAMMDispatcher, IAMMDispatcherTrait};
use konoha::traits::{IERC20Dispatcher, IERC20DispatcherTrait};
use openzeppelin::access::ownable::interface::{
IOwnableTwoStep, IOwnableTwoStepDispatcherTrait, IOwnableTwoStepDispatcher
};

use openzeppelin::upgrades::interface::{IUpgradeableDispatcher, IUpgradeableDispatcherTrait};

fn get_important_addresses() -> (ContractAddress, ContractAddress, ContractAddress) {
let gov_contract_address: ContractAddress = testStorage::GOV_CONTRACT_ADDRESS
.try_into()
.unwrap();
let AMM_contract_address: ContractAddress = testStorage::AMM_CONTRACT_ADDRESS
let AMM_contract_address: ContractAddress = testStorage::CARMINE_AMM_CONTRACT_ADDRESS
.try_into()
.unwrap();
let contract = declare("Treasury").expect('unable to declare');
Expand Down Expand Up @@ -166,3 +165,104 @@ fn test_ownership_transfer() {
);
}

#[test]
#[should_panic(expected: ('Caller is not the pending owner',))]
fn test_revoked_ownership_transfer() {
let (gov_contract_address, _AMM_contract_address, treasury_contract_address) =
get_important_addresses();
let user2: ContractAddress = '0xUser2'.try_into().unwrap();

prank(
CheatTarget::One(treasury_contract_address), gov_contract_address, CheatSpan::TargetCalls(1)
);
IOwnableTwoStepDispatcher { contract_address: treasury_contract_address }
.transfer_ownership(user2);
assert(
IOwnableTwoStepDispatcher { contract_address: treasury_contract_address }
.pending_owner() == user2,
'Pending transfer failed'
);

// governance transfers ownership back to itself
prank(
CheatTarget::One(treasury_contract_address), gov_contract_address, CheatSpan::TargetCalls(1)
);
IOwnableTwoStepDispatcher { contract_address: treasury_contract_address }
.transfer_ownership(gov_contract_address);
assert(
IOwnableTwoStepDispatcher { contract_address: treasury_contract_address }
.owner() == gov_contract_address,
'owner transferred but shouldnt'
);

// user2 tries to accept but can't
prank(CheatTarget::One(treasury_contract_address), user2, CheatSpan::TargetCalls(1));
IOwnableTwoStepDispatcher { contract_address: treasury_contract_address }.accept_ownership();
}

#[test]
#[fork("MAINNET")]
fn test_deposit_withdraw_carmine() {
let (gov_contract_address, _AMM_contract_address, treasury_contract_address) =
get_important_addresses();
let eth_addr: ContractAddress =
0x049d36570d4e46f48e99674bd3fcc84644ddd6b96f7c741b1562b82f9e004dc7
.try_into()
.unwrap();
let sequencer_address: ContractAddress =
0x01176a1bd84444c89232ec27754698e5d2e7e1a7f1539f12027f28b23ec9f3d8
.try_into()
.unwrap(); // random whale

prank(CheatTarget::One(eth_addr), sequencer_address, CheatSpan::TargetCalls(1));
let transfer_dispatcher = IERC20Dispatcher { contract_address: eth_addr };
let oneeth = 1000000000000000000;
let to_deposit = 900000000000000000;
transfer_dispatcher.transfer(treasury_contract_address, oneeth);
assert(
transfer_dispatcher.balanceOf(treasury_contract_address) >= to_deposit, 'balance too low??'
);
prank(
CheatTarget::One(treasury_contract_address), gov_contract_address, CheatSpan::TargetCalls(1)
);

transfer_dispatcher.approve(treasury_contract_address, to_deposit);
let treasury_dispatcher = ITreasuryDispatcher { contract_address: treasury_contract_address };
prank(
CheatTarget::One(treasury_contract_address), gov_contract_address, CheatSpan::TargetCalls(2)
);
let usdc_addr: ContractAddress =
0x053c91253bc9682c04929ca02ed00b3e423f6710d2ee7e0d5ebb06f3ecf368a8
.try_into()
.unwrap();
treasury_dispatcher
.provide_liquidity_to_carm_AMM(eth_addr, usdc_addr, eth_addr, 0, to_deposit.into());

roll(
CheatTarget::All, get_block_number() + 1, CheatSpan::Indefinite
); // to bypass sandwich guard
treasury_dispatcher
.withdraw_liquidity(
eth_addr, usdc_addr, eth_addr, 0, (to_deposit - 100000000000000000).into()
);
assert(
transfer_dispatcher.balanceOf(treasury_contract_address) >= to_deposit, 'balance too low??'
);
}

#[test]
fn test_upgrade_treasury_contract() {
let (gov_contract_address, _AMM_contract_address, treasury_contract_address) =
get_important_addresses();

let new_class_hash: ClassHash =
0x03eb5d443f730133de67b82901cd4b038098c814ad21d811baef9cbd5daeafec
.try_into()
.unwrap();

// Ensure only the owner (governance) can upgrade the contract
prank(
CheatTarget::One(treasury_contract_address), gov_contract_address, CheatSpan::TargetCalls(1)
);
IUpgradeableDispatcher { contract_address: treasury_contract_address }.upgrade(new_class_hash);
}
Loading