feat: backend for discussion #88

Mystic-Nayy · 2024-05-27T17:13:42Z

No description provided.

Mystic-Nayy · 2024-05-27T17:19:52Z

@tensojka please take a look at what I've done so far. I haven't tested it yet though. I still need to implement the function that resolves starknet address to starknet.id and setup pinata to test it

tensojka

Looks fine so far, but I'm not sure whether Helia can only compute the CID without spawning a full node.

backend/package.json

tensojka · 2024-05-27T19:33:44Z

backend/src/ipfs.ts

+let helia: any;
+
+export const initializeHelia = async () => {
+  helia = await createHeliaHTTP();


Are you sure that Helia does not initialize a full node (one that connects to DHT)? We don't want that

backend/src/ipfs.ts

backend/tsconfig.json

tensojka · 2024-05-27T19:39:31Z

Whenever you want another review, re-request review from me please. Thanks

Mystic-Nayy · 2024-05-31T11:33:52Z

@tensojka I've made some changes to the code based on your review. The only thing not working yet is the resolution of starknet.id from address so I commented out the logic for that in ipfs.ts. Please check through and let me know what improvements can be made.

tensojka

Have you tested it? Does Helia give the same hash as IPFS? Is it really async and does it throw an error if it fails?

tensojka · 2024-06-01T10:56:40Z

backend/src/ipfs.ts

+import { getStarknetId } from "./starknet.js";
+
+const PINATA_JWT =
+  "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1c2VySW5mb3JtYXRpb24iOnsiaWQiOiJmYjMxZmY2Ny0wNGZmLTQ2YWYtOTc1NC00MDZiNTQ5MDhlOWYiLCJlbWFpbCI6ImVqZW1iaW9jaGU1MEBnbWFpbC5jb20iLCJlbWFpbF92ZXJpZmllZCI6dHJ1ZSwicGluX3BvbGljeSI6eyJyZWdpb25zIjpbeyJpZCI6IkZSQTEiLCJkZXNpcmVkUmVwbGljYXRpb25Db3VudCI6MX0seyJpZCI6Ik5ZQzEiLCJkZXNpcmVkUmVwbGljYXRpb25Db3VudCI6MX1dLCJ2ZXJzaW9uIjoxfSwibWZhX2VuYWJsZWQiOmZhbHNlLCJzdGF0dXMiOiJBQ1RJVkUifSwiYXV0aGVudGljYXRpb25UeXBlIjoic2NvcGVkS2V5Iiwic2NvcGVkS2V5S2V5IjoiMjQ1ZDhkMmExMjg1ZWM1YWZlNjAiLCJzY29wZWRLZXlTZWNyZXQiOiI3OWI1NWM3MzZkZjBkODI2MjNiOWMxZDBhMzkxMjNlOTljNjhiNjE0ZDgwZGI2ZWI5OGM0MzIzZWM3MzI1OWUzIiwiaWF0IjoxNzE3MTAxNjU2fQ.N3pHXlmJsN0HZpkHUp2RMYF49C90WmwzNBTSjLxNzNc";


A bot just read this JWT and it's compromised. You must load it from an environment variable.

Don't forget to revoke this JWT and generate a new one.

A bot just read this JWT and it's compromised. You must load it from an environment variable.
Yea, it was careless mistake by me. I'll fix it

Mystic-Nayy · 2024-06-01T14:17:52Z

Have you tested it? Does Helia give the same hash as IPFS? Is it really async and does it throw an error if it fails?

@tensojka I have tested it out locally and can confirm that all functionalities are operating as expected. However, please note that Pinata requires a premium subscription for pinning by hash. As such, I was unable to fully verify this specific feature. The attached screenshot provides additional context on this matter.

tensojka · 2024-06-01T14:46:05Z

You can't use pinning by hash – pinning by hash works by Pinata fetching the file according to the hash from IPFS, but we don't want to operate a IPFS node that would serve the file to Pinata. Therefore, you must send the file to Pinata and have them generate the hash. (And check that their hash is the same as the one sent to the client)

Mystic-Nayy · 2024-06-01T14:47:51Z

You can't use pinning by hash – pinning by hash works by Pinata fetching the file according to the hash from IPFS, but we don't want to operate a IPFS node that would serve the file to Pinata. Therefore, you must send the file to Pinata and have them generate the hash. (And check that their hash is the same as the one sent to the client)

Oh okay. Got it!

Mystic-Nayy · 2024-06-01T15:43:43Z

@tensojka I effected the changes you requested. The screenshot below shows that result I got from testing.

tensojka

Great, I was able to load it from IPFS!

tensojka · 2024-06-01T17:00:25Z

backend/src/ipfs.ts

+export const submitProposal = async (req: Request, res: Response) => {
+  const { text, address } = req.body;
+
+  if (!text || !address) {
+    return res.status(400).json({ error: "Missing text or address" });
+  }
+
+  const proposalData: Proposal = {
+    text,
+    address
+  };


You should add assertions about the address and possibly also the text (max length) so this can't be used to store arbitrary data.

What max length do you think is convenient?

tensojka · 2024-06-01T17:01:17Z

I will get it working tomorrow 👌

tensojka · 2024-06-01T17:11:37Z

backend/src/starknet.ts

+  address: string
+): Promise<string | null> => {
+  const provider = new RpcProvider({
+    nodeUrl: "your_mainnet_node_url",


Use our node URL from Scarb.toml – http://34.22.208.73:6060/v0_7

Or better, load it from an environment variable

tensojka · 2024-06-01T17:14:33Z

deployed at https://konoha.vote/discussion-api/api/submit

- add type assertions and validations to `text` and `address`

tensojka

Otherwise lgtm!

tensojka · 2024-06-02T13:30:50Z

backend/src/ipfs.ts

+  starknet_id?: string;
+}
+
+const ADDRES_REGEX: RegExp = /^0x0[0-9a-fA-F]{63}$/;


this will match only addresses starting with 0x0 no?

Address can be even 0x1234

Also, not necessarily 63

Alright, will fix it right away

should be 64 actually, 0x is two, 64 is the rest

tensojka · 2024-06-02T13:31:47Z

backend/src/ipfs.ts

+}
+
+const ADDRES_REGEX: RegExp = /^0x0[0-9a-fA-F]{63}$/;
+const MAX_LENGTH: number = 200;


10k should be fine, no reason to constrain it a lot

tensojka

LGTM, thanks!

backend/src/starknet.ts

tensojka

Bug still not fixed :( 👎

backend/src/starknet.ts

feat: backend for discussion

218fa5d

tensojka reviewed May 27, 2024

View reviewed changes

feat: backend for discussion

b6df6b9

tensojka requested changes Jun 1, 2024

View reviewed changes

feat: backend for discussion

c500514

Mystic-Nayy requested a review from tensojka June 1, 2024 14:20

feat: pin to pinata

1b36c3e

tensojka reviewed Jun 1, 2024

View reviewed changes

tensojka marked this pull request as ready for review June 1, 2024 17:01

tensojka reviewed Jun 1, 2024

View reviewed changes

feat: implement starknet.id retrieval

a8b4db9

- add type assertions and validations to `text` and `address`

Mystic-Nayy requested a review from tensojka June 2, 2024 11:33

tensojka requested changes Jun 2, 2024

View reviewed changes

Mystic-Nayy added 2 commits June 2, 2024 14:44

refac: modify ADDRESS_REGEX and MAX_LENGTH

42d63bd

refac: modify ADDRESS_REGEX

ba4ffa4

Mystic-Nayy requested a review from tensojka June 2, 2024 13:48

tensojka approved these changes Jun 3, 2024

View reviewed changes

tensojka requested changes Jun 4, 2024

View reviewed changes

backend/src/starknet.ts Outdated Show resolved Hide resolved

fix: fix getStarkName() causing backend to fail

c4fbdef

Mystic-Nayy requested a review from tensojka June 5, 2024 15:42

tensojka requested changes Jun 8, 2024

View reviewed changes

backend/src/starknet.ts Outdated Show resolved Hide resolved

Mystic-Nayy added 2 commits June 10, 2024 08:57

fix: fix getStarknetId() crashing

552d9aa

test: add tests

4688b69

Mystic-Nayy requested a review from tensojka June 10, 2024 15:21

tensojka approved these changes Jul 26, 2024

View reviewed changes

tensojka merged commit 4d56ae2 into CarmineOptions:master Jul 26, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: backend for discussion #88

feat: backend for discussion #88

Mystic-Nayy commented May 27, 2024

Mystic-Nayy commented May 27, 2024

tensojka left a comment

tensojka May 27, 2024

tensojka commented May 27, 2024

Mystic-Nayy commented May 31, 2024

tensojka left a comment

tensojka Jun 1, 2024

tensojka Jun 1, 2024

Mystic-Nayy Jun 1, 2024

Mystic-Nayy commented Jun 1, 2024

tensojka commented Jun 1, 2024

Mystic-Nayy commented Jun 1, 2024

Mystic-Nayy commented Jun 1, 2024

tensojka left a comment

tensojka Jun 1, 2024

Mystic-Nayy Jun 1, 2024

Mystic-Nayy Jun 1, 2024

tensojka commented Jun 1, 2024

tensojka Jun 1, 2024

Mystic-Nayy Jun 2, 2024

tensojka commented Jun 1, 2024 •

edited

Loading

tensojka left a comment

tensojka Jun 2, 2024

Mystic-Nayy Jun 2, 2024

tensojka Jun 2, 2024

Mystic-Nayy Jun 2, 2024

tensojka Jun 2, 2024

Mystic-Nayy Jun 2, 2024

tensojka left a comment

tensojka left a comment

feat: backend for discussion #88

feat: backend for discussion #88

Conversation

Mystic-Nayy commented May 27, 2024

Mystic-Nayy commented May 27, 2024

tensojka left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tensojka commented May 27, 2024

Mystic-Nayy commented May 31, 2024

tensojka left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mystic-Nayy commented Jun 1, 2024

tensojka commented Jun 1, 2024

Mystic-Nayy commented Jun 1, 2024

Mystic-Nayy commented Jun 1, 2024

tensojka left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tensojka commented Jun 1, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tensojka commented Jun 1, 2024 • edited Loading

tensojka left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tensojka left a comment

Choose a reason for hiding this comment

tensojka left a comment

Choose a reason for hiding this comment

tensojka commented Jun 1, 2024 •

edited

Loading