Refactor getAllExperimentConditions function for proper readability #2171
+699
−299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppratikcr7
changed the title
VivekFitkariwala
previously requested changes
Jan 23, 2025
backend/packages/Upgrade/src/api/services/ExperimentAssignmentService.ts
Outdated
Show resolved
Hide resolved
backend/packages/Upgrade/src/api/services/ExperimentAssignmentService.ts
Outdated
Show resolved
Hide resolved
backend/packages/Upgrade/src/api/services/ExperimentAssignmentService.ts
Outdated
Show resolved
Hide resolved
backend/packages/Upgrade/src/api/services/ExperimentAssignmentService.ts
Outdated
Show resolved
Hide resolved
backend/packages/Upgrade/src/api/services/ExperimentAssignmentService.ts
Show resolved
Hide resolved
| // Create new filtered experiment list | ||
| const alreadyAssignedExperiments = experimentPools.map((pool) => { | ||
| return pool.filter((experiment) => { | ||
| const individualEnrollment = mergedIndividualAssignment.find((enrollment) => { |
There was a problem hiding this comment.
This is not fixed
There was a problem hiding this comment.
Already updated the alreadyAssignedExperiments to priorSelectedExperiments. Did you mean to update something else?
There was a problem hiding this comment.
If we click the file from this conversation, it will take us to an outdated file, so changes wont be seen. We need to review it from the File Changes tab.
There was a problem hiding this comment.
No the change I was asking for was to change find -> some
hasIndividualEnrollment and hasGroupEnrollment
backend/packages/Upgrade/src/api/services/ExperimentAssignmentService.ts
Outdated
Show resolved
Hide resolved
backend/packages/Upgrade/src/api/services/ExperimentAssignmentService.ts
Show resolved
Hide resolved
backend/packages/Upgrade/src/api/services/ExperimentAssignmentService.ts
Show resolved
Hide resolved
backend/packages/Upgrade/src/api/services/ExperimentAssignmentService.ts
Outdated
Show resolved
Hide resolved
|
@ppratikcr7 can you add test cases for the new functions added in the PR? |
…into optimize-getAllExperimentConditions
ppratikcr7
commented
Feb 4, 2025
backend/packages/Upgrade/src/api/services/ExperimentAssignmentService.ts
Show resolved
Hide resolved
ppratikcr7
commented
Feb 4, 2025
backend/packages/Upgrade/src/api/services/ExperimentAssignmentService.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focus on adding helper functions for getAllExperimentConditions and reduce the complexity of the code. I have also added comments for better understanding.