Add spatial interpolation #153
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| target: Node.PARAM.NODE(Node.GEOMETRY.ANY), | ||
| column: Node.PARAM.STRING(), | ||
| method: Node.PARAM.NULLABLE(Node.PARAM.NUMBER()), | ||
| p1: Node.PARAM.NULLABLE(Node.PARAM.NUMBER()), |
There was a problem hiding this comment.
if p1 refers to number of neighbours. Could we use numberOfNeighbours as param name?
|
👍 |
|
Fixed:
Now I like my own code much more :) cc @rochoa |
| // column of values in source dataset | ||
| column: Node.PARAM.STRING(), | ||
| // 0: nearest neighbor, 1: barymetric, 2: IDW | ||
| method: Node.PARAM.NULLABLE(Node.PARAM.ENUM('nearest neighbor', 'barymetric','IDW'),'barymetric'), |
There was a problem hiding this comment.
Avoid spaces in ENUM values.
|
|
||
| var Node = require('../node'); | ||
|
|
||
| var TYPE = 'enrich'; |
There was a problem hiding this comment.
TYPE and filename should match.
|
I'll add the tests these days and assign you the CR, @dgaubert. Sorry! ¯_(ツ)_/¯ |
added 11 commits
September 19, 2016 08:38
dgaubert
reviewed
Sep 21, 2016
| sourceQuery: this.source.getQuery(), | ||
| targetQuery: this.target.getQuery(), | ||
| val_column: this.val_column, | ||
| method: ['nearest_neighbor', 'barymetric','IDW'].indexOf[this.method], |
There was a problem hiding this comment.
indexOf is a function, don't use [] on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For new analysis use the following checklist:
the_geom geometry(Geometry, 4326)column.cartodb_id numericcolumn.{cache: true}option when it needs full knowledge of the table it. Hints: aggregations, window functions.{cache: true}if it access external services.cc @javisantana