Used st_collect only when it's needed
#178
Conversation
|
|
||
| var TYPE = 'centroid'; | ||
|
|
||
| var PARAMS = { | ||
| source : Node.PARAM.NODE(Node.GEOMETRY.ANY), | ||
| category_column : Node.PARAM.NULLABLE(Node.PARAM.STRING()), | ||
| aggregation: Node.PARAM.NULLABLE(Node.PARAM.STRING(), 'count'), | ||
| aggregation_column: Node.PARAM.NULLABLE(Node.PARAM.STRING()) | ||
| aggregation: Node.PARAM.NULLABLE(Node.PARAM.ENUM('avg', 'count', 'max', 'min', 'sum'), null), |
There was a problem hiding this comment.
Why do we change the default count?
There was a problem hiding this comment.
To make it a real nullable; if aggregation comes with null then the ENUM replaces it with count and never is null
There was a problem hiding this comment.
But that's the purpose of having a default value, isn't it?
There was a problem hiding this comment.
here we need a nullable enum, if aggregation comes with null value, we shouldn't set count as default, should we?
There was a problem hiding this comment.
Why not? I mean, it's nice to have the count by default, isn't it?
There was a problem hiding this comment.
😕 Well I'm not sure, when I used the Builder I have to check the checkbox to select aggregation function:
There was a problem hiding this comment.
That doesn't mean the node/analysis has to follow those defaults.
There was a problem hiding this comment.
But if category_column is null and st_collect is not used, we are forcing to have a count column filled entirely with 1. right?
There was a problem hiding this comment.
If there is no category column the aggregation doesn't matter so you just don't do it. It will happen the same if there is no category column and the user provides an aggregation operation and an aggregation column, right?
There was a problem hiding this comment.
Yes, It will.
That's why we need to have the aggregation default to null to avoid to do aggregations if category column is not present.
I think, I don't get your point. 😢
|
CR: @rochoa |
Fixes #127, validates analysis for invalid inputs, uses
st_collectwhen needed.