Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underzoom example [ch106065] #4

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Underzoom example [ch106065] #4

wants to merge 5 commits into from

Conversation

neokore
Copy link
Contributor

@neokore neokore commented Sep 22, 2020

@neokore neokore changed the title Underzoom demo Underzoom demo [ch106065] Sep 22, 2020
@VictorVelarde
Copy link
Contributor

Question: should this example be included right now (for the first set of examples published at dev-center?). If that's the case we need a couple of small changes:

  • we should add in the header a http link to the temporary lib in our cdn (and comment the local path with ../../...), see other examples and copy.
  • we should include it in the 'examples.json' file

Copy link
Contributor

@VictorVelarde VictorVelarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A confirmation of when + 2 small changes would be needed

@neokore neokore changed the title Underzoom demo [ch106065] Underzoom example [ch106065] Sep 22, 2020
minZoom: 12,
maxZoom: 16,

// Allow underzooming by setting the bounding box of the layer.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need more clarification, something like this: by setting minZoom, maxZoom and autoExtent, the layer will be visible for zoom>16 but it will always use z=16 tiles, for zoom<12 the layer will be visible but it always use z=12 tiles

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

pointRadiusMinPixels: 6,
lineWidthMinPixels: 1,

// Define the zoom range of the layer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the tiles ranges

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean?

@neokore
Copy link
Contributor Author

neokore commented Sep 23, 2020

Question: should this example be included right now (for the first set of examples published at dev-center?). If that's the case we need a couple of small changes:

  • we should add in the header a http link to the temporary lib in our cdn (and comment the local path with ../../...), see other examples and copy.
  • we should include it in the 'examples.json' file

Not sure about when it should be included, but at least we may have to wait until the new autoExtent prop is merged into Deck.gl. Anyway, the requested changes are now applied. Thanks @VictorVelarde!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants