Download Prohibited apps (PlayCover#1502)

* Update Downloader.swift * better error description * SwiftLint fix * Added download anyway button * updated alert style Added "destructive" style to download anyway so it's clearer that is a not recommended action * Revert "updated alert style" This reverts commit ff6f45f. * added traslation added translation to Localizable.string and changed it to match PlayCover#1543
Catta1997 · Aug 25, 2024 · 0cfcffe · 0cfcffe
1 parent d645695
commit 0cfcffe
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/PlayCover/AppInstaller/Downloader.swift b/PlayCover/AppInstaller/Downloader.swift
@@ -39,11 +39,26 @@ class DownloadApp {
         if installVM.inProgress {
             Log.shared.error(PlayCoverError.waitInstallation)
         } else {
+            if let app = app, PlayApp.PROHIBITED_APPS.contains(app.bundleID) {
+                let alert = NSAlert()
+                alert.messageText = NSLocalizedString("alert.error", comment: "")
+                alert.informativeText = String(
+                    format: NSLocalizedString("error.appProhibited", comment: ""),
+                    arguments: [app.name]
+                )
+                alert.alertStyle = .warning
+                alert.addButton(withTitle: NSLocalizedString("Ok", comment: ""))
+                alert.addButton(withTitle: NSLocalizedString("alert.download.downloadAnyway", comment: ""))
+                if alert.runModal() == .alertFirstButtonReturn {
+                    return
+                }
+            }
+
             if let warningMessage = warning, let app = app {
                 let alert = NSAlert()
                 alert.messageText = NSLocalizedString(warningMessage, comment: "")
                 alert.informativeText = String(
-                    format: NSLocalizedString("ipaLibrary.alert.download", comment: ""),
+                    format: NSLocalizedString("alert.install.anyway", comment: ""),
                     arguments: [app.name]
                 )
                 alert.alertStyle = .warning

diff --git a/PlayCover/en.lproj/Localizable.strings b/PlayCover/en.lproj/Localizable.strings
@@ -284,3 +284,5 @@
 
 "keycover.alert.title" = "Keychain was not unlocked";
 "keycover.alert.content" = "Keychain access has been disabled for the current session";
+
+"alert.install.anyway" = "Install Anyway";
Original file line number	Diff line number	Diff line change
Expand Up		@@ -284,3 +284,5 @@

		"keycover.alert.title" = "Keychain was not unlocked";
		"keycover.alert.content" = "Keychain access has been disabled for the current session";

		"alert.install.anyway" = "Install Anyway";