Skip to content

Commit

Permalink
Merge pull request #212 from bugsnag/fix-client-session-start
Browse files Browse the repository at this point in the history 
Add missing param to client method
  • Loading branch information
@fractalwrench
fractalwrench authored Jan 30, 2018
2 parents 9c54fc3 + f27bbe6 commit 16da5e8
Show file tree
Hide file tree
Showing 2 changed files with 106 additions and 6 deletions.
7 changes: 6 additions & 1 deletion android/src/main/java/com/bugsnag/BugsnagReactNative.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import com.facebook.react.uimanager.ViewManager;

import android.content.Context;
import android.app.Activity;

import com.bugsnag.android.*;

Expand Down Expand Up @@ -262,7 +263,11 @@ private void configureRuntimeOptions(Client client, ReadableMap options) {
if (options.hasKey("autoCaptureSessions")) {
boolean autoCapture = options.getBoolean("autoCaptureSessions");
config.setAutoCaptureSessions(autoCapture);
client.startFirstSession();
Activity activity = getCurrentActivity();

if (activity != null) {
client.startFirstSession(getCurrentActivity());
}
}
}
}
Expand Down
105 changes: 100 additions & 5 deletions examples/plain/ios/BugsnagReactNativeExample.xcodeproj/project.pbxproj
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
2D02E4C61E0B4AEC006451C7 /* libRCTSettings-tvOS.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 3DAD3E901DF850E9000B6D8A /* libRCTSettings-tvOS.a */; };
2D02E4C71E0B4AEC006451C7 /* libRCTText-tvOS.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 3DAD3E941DF850E9000B6D8A /* libRCTText-tvOS.a */; };
2D02E4C81E0B4AEC006451C7 /* libRCTWebSocket-tvOS.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 3DAD3E991DF850E9000B6D8A /* libRCTWebSocket-tvOS.a */; };
2D02E4C91E0B4AEC006451C7 /* libReact-tvOS.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 3DAD3EA31DF850E9000B6D8A /* libReact-tvOS.a */; };
2D02E4C91E0B4AEC006451C7 /* libReact.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 3DAD3EA31DF850E9000B6D8A /* libReact.a */; };
2DCD954D1E0B4F2C00145EB5 /* BugsnagReactNativeExampleTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 00E356F21AD99517003FC87E /* BugsnagReactNativeExampleTests.m */; };
348547A9B452443DA8E0786E /* Entypo.ttf in Resources */ = {isa = PBXBuildFile; fileRef = AC31314F22BC4AE39D3FB949 /* Entypo.ttf */; };
37DAB24AE5434E61A8708C6F /* libBugsnagReactNative.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 31124543911F4AADA5E4DCD3 /* libBugsnagReactNative.a */; };
Expand Down Expand Up @@ -285,6 +285,48 @@
remoteGlobalIDString = 358F4ED71D1E81A9004DF814;
remoteInfo = RCTBlob;
};
E766475E20208BBA0037E950 /* PBXContainerItemProxy */ = {
isa = PBXContainerItemProxy;
containerPortal = 146833FF1AC3E56700842450 /* React.xcodeproj */;
proxyType = 2;
remoteGlobalIDString = 139D7ECE1E25DB7D00323FB7;
remoteInfo = "third-party";
};
E766476020208BBA0037E950 /* PBXContainerItemProxy */ = {
isa = PBXContainerItemProxy;
containerPortal = 146833FF1AC3E56700842450 /* React.xcodeproj */;
proxyType = 2;
remoteGlobalIDString = 3D383D3C1EBD27B6005632C8;
remoteInfo = "third-party-tvOS";
};
E766476220208BBA0037E950 /* PBXContainerItemProxy */ = {
isa = PBXContainerItemProxy;
containerPortal = 146833FF1AC3E56700842450 /* React.xcodeproj */;
proxyType = 2;
remoteGlobalIDString = 139D7E881E25C6D100323FB7;
remoteInfo = "double-conversion";
};
E766476420208BBA0037E950 /* PBXContainerItemProxy */ = {
isa = PBXContainerItemProxy;
containerPortal = 146833FF1AC3E56700842450 /* React.xcodeproj */;
proxyType = 2;
remoteGlobalIDString = 3D383D621EBD27B9005632C8;
remoteInfo = "double-conversion-tvOS";
};
E766476620208BBA0037E950 /* PBXContainerItemProxy */ = {
isa = PBXContainerItemProxy;
containerPortal = 146833FF1AC3E56700842450 /* React.xcodeproj */;
proxyType = 2;
remoteGlobalIDString = 9936F3131F5F2E4B0010BF04;
remoteInfo = privatedata;
};
E766476820208BBA0037E950 /* PBXContainerItemProxy */ = {
isa = PBXContainerItemProxy;
containerPortal = 146833FF1AC3E56700842450 /* React.xcodeproj */;
proxyType = 2;
remoteGlobalIDString = 9936F32F1F5F2E5B0010BF04;
remoteInfo = "privatedata-tvOS";
};
/* End PBXContainerItemProxy section */

/* Begin PBXFileReference section */
Expand Down Expand Up @@ -369,7 +411,7 @@
isa = PBXFrameworksBuildPhase;
buildActionMask = 2147483647;
files = (
2D02E4C91E0B4AEC006451C7 /* libReact-tvOS.a in Frameworks */,
2D02E4C91E0B4AEC006451C7 /* libReact.a in Frameworks */,
2D02E4C21E0B4AEC006451C7 /* libRCTAnimation.a in Frameworks */,
2D02E4C31E0B4AEC006451C7 /* libRCTImage-tvOS.a in Frameworks */,
2D02E4C41E0B4AEC006451C7 /* libRCTLinking-tvOS.a in Frameworks */,
Expand Down Expand Up @@ -489,13 +531,19 @@
isa = PBXGroup;
children = (
146834041AC3E56700842450 /* libReact.a */,
3DAD3EA31DF850E9000B6D8A /* libReact.a */,
3DAD3EA51DF850E9000B6D8A /* libyoga.a */,
3DAD3EA71DF850E9000B6D8A /* libyoga.a */,
3DAD3EA91DF850E9000B6D8A /* libcxxreact.a */,
3DAD3EAB1DF850E9000B6D8A /* libcxxreact.a */,
3DAD3EAD1DF850E9000B6D8A /* libjschelpers.a */,
3DAD3EAF1DF850E9000B6D8A /* libjschelpers.a */,
3DAD3EA31DF850E9000B6D8A /* libReact-tvOS.a */,
E766475F20208BBA0037E950 /* libthird-party.a */,
E766476120208BBA0037E950 /* libthird-party.a */,
E766476320208BBA0037E950 /* libdouble-conversion.a */,
E766476520208BBA0037E950 /* libdouble-conversion.a */,
E766476720208BBA0037E950 /* libprivatedata.a */,
E766476920208BBA0037E950 /* libprivatedata-tvOS.a */,
);
name = Products;
sourceTree = "<group>";
Expand Down Expand Up @@ -732,6 +780,7 @@
TestTargetID = 13B07F861A680F5B00A75B9A;
};
13B07F861A680F5B00A75B9A = {
DevelopmentTeam = 372ZUL2ZB7;
LastSwiftMigration = "";
};
2D02E47A1E0B4A5D006451C7 = {
Expand Down Expand Up @@ -923,10 +972,10 @@
remoteRef = 3DAD3E981DF850E9000B6D8A /* PBXContainerItemProxy */;
sourceTree = BUILT_PRODUCTS_DIR;
};
3DAD3EA31DF850E9000B6D8A /* libReact-tvOS.a */ = {
3DAD3EA31DF850E9000B6D8A /* libReact.a */ = {
isa = PBXReferenceProxy;
fileType = archive.ar;
path = "libReact-tvOS.a";
path = libReact.a;
remoteRef = 3DAD3EA21DF850E9000B6D8A /* PBXContainerItemProxy */;
sourceTree = BUILT_PRODUCTS_DIR;
};
Expand Down Expand Up @@ -1042,6 +1091,48 @@
remoteRef = ADBDB9261DFEBF0700ED6528 /* PBXContainerItemProxy */;
sourceTree = BUILT_PRODUCTS_DIR;
};
E766475F20208BBA0037E950 /* libthird-party.a */ = {
isa = PBXReferenceProxy;
fileType = archive.ar;
path = "libthird-party.a";
remoteRef = E766475E20208BBA0037E950 /* PBXContainerItemProxy */;
sourceTree = BUILT_PRODUCTS_DIR;
};
E766476120208BBA0037E950 /* libthird-party.a */ = {
isa = PBXReferenceProxy;
fileType = archive.ar;
path = "libthird-party.a";
remoteRef = E766476020208BBA0037E950 /* PBXContainerItemProxy */;
sourceTree = BUILT_PRODUCTS_DIR;
};
E766476320208BBA0037E950 /* libdouble-conversion.a */ = {
isa = PBXReferenceProxy;
fileType = archive.ar;
path = "libdouble-conversion.a";
remoteRef = E766476220208BBA0037E950 /* PBXContainerItemProxy */;
sourceTree = BUILT_PRODUCTS_DIR;
};
E766476520208BBA0037E950 /* libdouble-conversion.a */ = {
isa = PBXReferenceProxy;
fileType = archive.ar;
path = "libdouble-conversion.a";
remoteRef = E766476420208BBA0037E950 /* PBXContainerItemProxy */;
sourceTree = BUILT_PRODUCTS_DIR;
};
E766476720208BBA0037E950 /* libprivatedata.a */ = {
isa = PBXReferenceProxy;
fileType = archive.ar;
path = libprivatedata.a;
remoteRef = E766476620208BBA0037E950 /* PBXContainerItemProxy */;
sourceTree = BUILT_PRODUCTS_DIR;
};
E766476920208BBA0037E950 /* libprivatedata-tvOS.a */ = {
isa = PBXReferenceProxy;
fileType = archive.ar;
path = "libprivatedata-tvOS.a";
remoteRef = E766476820208BBA0037E950 /* PBXContainerItemProxy */;
sourceTree = BUILT_PRODUCTS_DIR;
};
/* End PBXReferenceProxy section */

/* Begin PBXResourcesBuildPhase section */
Expand Down Expand Up @@ -1247,6 +1338,7 @@
CLANG_ENABLE_MODULES = YES;
CURRENT_PROJECT_VERSION = 1;
DEAD_CODE_STRIPPING = NO;
DEVELOPMENT_TEAM = 372ZUL2ZB7;
HEADER_SEARCH_PATHS = (
"$(inherited)",
"$(SRCROOT)/../node_modules/bugsnag-react-native/cocoa/**",
Expand All @@ -1259,6 +1351,7 @@
"-ObjC",
"-lc++",
);
PRODUCT_BUNDLE_IDENTIFIER = com.bugsnag.reactnative.example;
PRODUCT_NAME = BugsnagReactNativeExample;
SWIFT_OBJC_BRIDGING_HEADER = "BugsnagReactNativeExample-Bridging-Header.h";
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
Expand All @@ -1274,6 +1367,7 @@
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
CLANG_ENABLE_MODULES = YES;
CURRENT_PROJECT_VERSION = 1;
DEVELOPMENT_TEAM = 372ZUL2ZB7;
HEADER_SEARCH_PATHS = (
"$(inherited)",
"$(SRCROOT)/../node_modules/bugsnag-react-native/cocoa/**",
Expand All @@ -1286,6 +1380,7 @@
"-ObjC",
"-lc++",
);
PRODUCT_BUNDLE_IDENTIFIER = com.bugsnag.reactnative.example;
PRODUCT_NAME = BugsnagReactNativeExample;
SWIFT_OBJC_BRIDGING_HEADER = "BugsnagReactNativeExample-Bridging-Header.h";
SWIFT_SWIFT3_OBJC_INFERENCE = On;
Expand Down

0 comments on commit 16da5e8

Please sign in to comment.