Feature/preprint details page #2026
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
futa-ikeda
reviewed
Oct 12, 2023
adlius
requested changes
Oct 16, 2023
brianjgeiger
requested changes
Oct 16, 2023
lib/osf-components/addon/components/branded-header/component.ts
Outdated
Show resolved
Hide resolved
futa-ikeda
requested changes
Oct 17, 2023
- Ticket: [ENG-4450] - Feature flag: n/a - Add new models needed for SHARE-powered search page - Add new models - `metadata-record-search` - `metadata-property-search` - `metadata-value-search` - `metadata-record` - `search-match` - New `ShareAdapter` and `ShareSerializer` to be used by these new models - New mirage endpoint for metadata-record-search (other endpoints coming later)
- Ticket: [ENG-4465] [ENG-4466] - Feature flag: n/a - Add logic to search page controller to handle active filters and list of filterable properties - Add a component to handle fetching values in a filterable properties in the search page - Add a `filter-facet` component - takes care of fetching filterable property values - `See more` modal
- Ticket: [ENG-4469] - Feature flag: n/a - Add object type filter and sort dropdown to search page - Add tabs to filter by object type (All, Projects, Registrations, Preprints, Files, Users) - Add dropdown to sort results by Relevance, Date modified/created ascending and descending - Change model names to reflect more library-analogy based names - Change how metadata properties are fetched from SHARE models
- Ticket: [No ticket] - Feature flag: n/a - Update SHAREAdapter to point to correct locations - Update SHAREAdapter parent class to point use config variable for share-url - Update SHAREAdapter parent class to point use api/v3 endpoints - Update search-related adapters to point to singularized endpoint names (e.g. api/v3/index-card-search**es** -> api/v3/index-card-search - Update mirage endpoints to reflect these changes
- Ticket: [ENG-4568] - Feature flag: n/a - Componentize search page for reuse in branded pages - Move logic and templating from search page route to `search-page` component - No logic for branding and default query-params yet in this PR
* add brand relationship to preprint provider model (#1887) * Remove unused services from search controller * Use search-page component on preprint discover page * Modifiy branded-navbar for preprints * Error handling and theme resetting * Branded preprint discover part 1 * Branded preprint discover part 2 * Test prerpint discover page * Group CR feedback re: search-page component arguments * Fix test --------- Co-authored-by: Yuhuai Liu <[email protected]>
* preliminary * moar * some more * delete unused components * remove top-level aggregate registries discover route * remove top-level registries discover route cont. * remove unused action and variable on registries application route * remove aggregate registries discover page tests * fix tests * remove discover-test.ts * CR followup
- Ticket: [ENG-4574]
- Feature flag: n/a
- Add appropriate page title to discover page
- Add appropriate analytics scope to discover page
- Make provider description now show html entities
- Use `{{html-safe}}` when showing provider description
- Add `providerTitle` in preprint-provider model
- Most branded providers should show their name with their preprint word (e.g. AfricaRxiv Preprints, MarXiv Papers), except Thesis Commons
- If it's OSF, we just show "OSF Preprints"
- Add page-title and analytics scope using the new `providerTitle`
- Ticket: [ENG-4535] - Feature flag: n/a - Add search help feature - Basically a re-implementation of #1891 and #1877 - Notable difference is moving the Popovers to the end of the file to avoid merge conflicts - Added EmberPopovers to the search-page component - Added getters to search-page component to fetch EmberPopover targets dynamically - Translations - Tests
…rceType (#1915) * change queryparam passed to SHARE when filtering by resourceType * add types * add some more types * update tests
- Ticket: [] - Feature flag: n/a - Only rely on `brand` relationship for setting preprint colors - Use `brand.primaryColor` for branded navbar background color - Add styling if the brand's primaryColor does not provide sufficient contrast with white text - Add special-case for BioHackrXiv to change navbar color to white (their primary color would be white, but that creates problems for `<Button>` behavior, so their primary is black instead) - Use `brand.heroBackgroundImage` for hero banner background, as well as advisory board section when @brianpilati implements that page. Currently just a solid color - Use `brand.navbarLogoImage` for navbar logo if `preprintProvider.assets.square_color_transparent` is not defined - Update `<Button>` component to detect primary color and use white/black text depending on color contrast
- Ticket: [] - Feature flag: n/a ## Purpose - Remove possible failure point by not using preprintProvider.asset - Add special casing to address nutrixiv's navbar color https://osf.io/preprints/nutrixiv/ ## Summary of Changes - Remove use of ThemeStyles from preprint (this set the navbar logo to use the preprintProvider.asset. square_color_transparent, when we want to just use the brand. topnavLogoImage going forward) - Add special case for nutrixiv to use a white background similar to biohackrxiv
bp-cos
force-pushed
the
feature/preprint-details-page
branch
from
a3c175d to
4acbbc9
Compare
|
Temporarily closed to avoid percy runs. Will reopen later when things are stabilized. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Port the preprint details page from osf-preprints to osf-web
Summary of Changes
Rewrite of the osf-preprint components
Screenshot(s)
Desktop in OSF-Preprints
Desktop in OSF-Web
Mobile in OSF-Preprints
preprints - mobile - before 4
Mobile in OSF-Web
**Tombstone Desktop **
**Tombstone Mobile **
** Rejected Desktop **
** Rejected Mobile **
** Approved - Author Assertions - Desktop **
** Approved - Author Assertions - Mobile **
The Preprint Doi is blank when
Side Effects
Massive testing
QA Notes
The preprint details page will need to be regressed