Prevent mutation after consumption

[futa-ikeda]

• Ticket: []
• Feature flag: n/a

Purpose

• Prevent hitting this deprecation on search page (thank you @adlius for finding this): https://deprecations.emberjs.com/v3.x/#toc_autotracking-mutation-after-consumption

Summary of Changes

• Move logic to update query params before the search task
• Rename onSearch argument to onQueryParamChange for more clarity

Screenshot(s)

Side Effects

QA Notes

[coveralls]

Pull Request Test Coverage Report for Build 6615496946

• 7 of 11 (63.64%) changed or added relevant lines in 2 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage decreased (-0.02%) to 70.651%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
lib/osf-components/addon/components/search-page/component.ts	7	8	87.5%
lib/registries/addon/branded/discover/controller.ts	0	3	0.0%

Files with Coverage Reduction	New Missed Lines	%
lib/osf-components/addon/components/search-page/component.ts	1	77.86%

Totals
Change from base Build 6615395637:	-0.02%
Covered Lines:	5950
Relevant Lines:	8191

---

💛 - Coveralls

[brianjgeiger]

I think this basically makes sense. These types of problems are a pain.

[adlius]

Have you run the tests locally with the deprecation id removed from deprecation-workflow.js and deprecation breakpoints added to see if the tests hit the breakpoints?

[futa-ikeda]

Have you run the tests locally with the deprecation id removed from deprecation-workflow.js and deprecation breakpoints added to see if the tests hit the breakpoints?

I had ran the test suite to only run tests pertaining to "search", but will rerun the entire test suite now, just to make sure. Verified that it was no longer logging the deprecations when using the search page as well.

[adlius]

Do we have a branch for post-release search work? If so, we'd probably want to merge this into that branch.

[futa-ikeda]

I've just been merging things for the post-release stuff into develop. It should be going out early next week