Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consistent cardSearchText for value-search #2035

Merged

Conversation

aaxelb
Copy link
Contributor

@aaxelb aaxelb commented Oct 23, 2023

  • Ticket: []
  • Feature flag: n/a

Purpose

correct creator-facet behavior when already searching by creator name in free-text search

Summary of Changes

send same cardSearchText param for index-value-search as already used for index-card-search

Screenshot(s)

Side Effects

QA Notes

on the search page:

  1. search by a creator name in the main search box (note the creator in search results)
  2. click on the "Creator" facet and search by the same creator name
  3. should be able to select and filter by the creator in question

@aaxelb aaxelb force-pushed the fix/valuesearch-cardsearchtext branch from 047cddf to 2f71005 Compare October 23, 2023 15:04
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6615179049

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 70.672%

Totals Coverage Status
Change from base Build 6614989946: 0.002%
Covered Lines: 5949
Relevant Lines: 8186

💛 - Coveralls

@aaxelb aaxelb merged commit e41d1ad into CenterForOpenScience:develop Oct 23, 2023
9 checks passed
@aaxelb aaxelb deleted the fix/valuesearch-cardsearchtext branch October 23, 2023 15:21
@futa-ikeda futa-ikeda added this to the 23.13.0 milestone Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants