Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-4838] Update search-result card to show preprint word #2036

Merged
merged 6 commits into from
Oct 23, 2023
Merged

[ENG-4838] Update search-result card to show preprint word #2036

merged 6 commits into from
Oct 23, 2023

Conversation

futa-ikeda
Copy link
Contributor

@futa-ikeda futa-ikeda commented Oct 23, 2023 •
edited by jira bot
Loading

Purpose

  • Don't show "PREPRINT" on search result card for branded preprint provider discover page

Summary of Changes

  • Pass provider to search-result card
    • Check result type and provider's preprintWord
  • Update Preprint Provider word to just Provider

Screenshot(s)

  • For preprint provider's discover page:
    image

Side Effects

QA Notes

@coveralls
Copy link

coveralls commented Oct 23, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6617869913

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.651%
Totals Coverage Status
Change from base Build 6615727596: 0.0%
Covered Lines: 5953
Relevant Lines: 8194
💛 - Coveralls

aaxelb
aaxelb previously approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@aaxelb aaxelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noted a nit, but since this pr didn't introduce it (and isn't the only place it happens), not a big problem

lib/osf-components/addon/components/search-result-card/component.ts Outdated Show resolved Hide resolved
@futa-ikeda futa-ikeda added this to the 23.13.0 milestone Oct 23, 2023
aaxelb
aaxelb requested changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@aaxelb aaxelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oop, another translation nit i didn't think of before

lib/osf-components/addon/components/search-result-card/component.ts Outdated Show resolved Hide resolved
aaxelb
aaxelb approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@aaxelb aaxelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍨

@futa-ikeda futa-ikeda merged commit 9f5c1e3 into CenterForOpenScience:develop Oct 23, 2023
9 checks passed
@futa-ikeda futa-ikeda deleted the preprint-label branch October 23, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaxelb aaxelb aaxelb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
23.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@futa-ikeda @coveralls @aaxelb