Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-6448] Update preprint-doi component to handle versions #2420

Conversation

futa-ikeda
Copy link
Contributor

@futa-ikeda futa-ikeda commented Dec 4, 2024

Purpose

  • Update preprint-doi component to handle versions

Summary of Changes

  • Update Preprints::PreprintDoi component
    • Takes an array of versions, rather than a single preprint
    • Add dropdown to select a specific version
    • Tests

Screenshot(s)

  • Example of a preprint with a fully minted DOI (from tests, so that's why the background is weird):
    image

  • Example of a preprint that has a DOI, but it is pending:
    image

  • Example of preprint with no DOI due to it pending moderation (from tests, so that's why the background is weird)

image

Side Effects

QA Notes

@futa-ikeda futa-ikeda marked this pull request as draft December 4, 2024 15:39
@futa-ikeda futa-ikeda marked this pull request as ready for review December 4, 2024 15:47
Copy link
Contributor

@brianjgeiger brianjgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I did have a comment around some wording, but it looks like that's existing wording, so Product should have approved it already.

Copy link
Collaborator

@cslzchen cslzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this include the labels for (pending/withdrawn/rejected)? @futa-ikeda I know we have another ticket for withdrawn and pending initially, so I think we will do labels later?

@futa-ikeda
Copy link
Contributor Author

Will this include the labels for (pending/withdrawn/rejected)? @futa-ikeda I know we have another ticket for withdrawn and pending initially, so I think we will do labels later?

This doesn't add the pending/withdrawn/rejected labels. It should be fairly simple to add later though

@futa-ikeda futa-ikeda merged commit 485756a into CenterForOpenScience:feature/preprints-doi-versioning Dec 4, 2024
9 checks passed
@futa-ikeda futa-ikeda deleted the doi-dropdown branch December 4, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants