[ENG-6665] Add user messaging modal to user's tab on institutional dashboard #2421
+192
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12303026020Details
💛 - Coveralls |
Johnetordoff
commented
Dec 5, 2024
app/institutions/dashboard/-components/institutional-users-list/styles.scss
Outdated
Show resolved
Hide resolved
Johnetordoff
force-pushed
the
institutional-access-user-message-modal
branch
from
e91a7f1 to
8375eb7
Compare
futa-ikeda
reviewed
Dec 6, 2024
app/institutions/dashboard/-components/institutional-users-list/template.hbs
Outdated
Show resolved
Hide resolved
app/institutions/dashboard/-components/institutional-users-list/template.hbs
Outdated
Show resolved
Hide resolved
app/institutions/dashboard/-components/institutional-users-list/template.hbs
Outdated
Show resolved
Hide resolved
app/institutions/dashboard/-components/institutional-users-list/component.ts
Outdated
Show resolved
Hide resolved
app/institutions/dashboard/-components/institutional-users-list/template.hbs
Outdated
Show resolved
Hide resolved
|
@futa-ikeda Based on the ARB, we decided we wanted two additional features here:
So bare with me as I address your comments, but also add those two things in the next iteration. |
Johnetordoff
force-pushed
the
institutional-access-user-message-modal
branch
from
7c80ef4 to
28aadaf
Compare
…er-osf-web into institutional-access-user-message-modal * 'develop' of https://github.com/CenterForOpenScience/ember-osf-web: Update CHANGELOG, bump version [ENG-5024] Feature/dashboard b and i (CenterForOpenScience#2429) # Conflicts: # app/institutions/dashboard/-components/institutional-users-list/component.ts
futa-ikeda
reviewed
Dec 13, 2024
app/institutions/dashboard/-components/institutional-users-list/component.ts
Outdated
Show resolved
Hide resolved
app/institutions/dashboard/-components/institutional-users-list/template.hbs
Outdated
Show resolved
Hide resolved
app/institutions/dashboard/-components/institutional-users-list/template.hbs
Outdated
Show resolved
Hide resolved
app/institutions/dashboard/-components/institutional-users-list/component.ts
Outdated
Show resolved
Hide resolved
app/institutions/dashboard/-components/institutional-users-list/component.ts
Outdated
Show resolved
Hide resolved
app/institutions/dashboard/-components/institutional-users-list/component.ts
Outdated
Show resolved
Hide resolved
|
@Johnetordoff This should be pointing to a feature branch based off of develop, please. |
Johnetordoff
changed the base branch from
develop
to
feature/institutional-dashboard
Johnetordoff
changed the base branch from
feature/institutional-dashboard
to
feature/institutional-access
Johnetordoff
merged commit 5bbb5a3
into
CenterForOpenScience:feature/institutional-access
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Adds a modal that allows an institutional admin to send a message through a text input as part of an email template.
Summary of Changes
Screenshot(s)
Side Effects
QA Notes