-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-6459][ENG-6637][ENG-6638] Add Create new preprint version button #2423
[ENG-6459][ENG-6637][ENG-6638] Add Create new preprint version button #2423
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of TODOs in those tests, but I presume they'll come with later tickets.
Well those aren't helpful test failure messages
|
app/models/preprint.ts
Outdated
ReviewsState.WITHDRAWAL_REJECTED, | ||
ReviewsState.PENDING_WITHDRAWAL, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I didn't know withdrawal can have pending and rejected states. I need to check BE to see if we are handling this properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@futa-ikeda for pre-moderation, "accepted" is correct but for post moderation, it should be "pending" or " accepted". I am not 100% sure how frontend maps backend wording.
See: https://openscience.atlassian.net/browse/ENG-6467. I think FE can probably just use the is_lateset_version
without caring about the review state?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, interesting... I see what you are saying about some of the reviews_states for pre-mod vs. post-mod lining up to be the same state (ie: for pre-mod, "reviews_state": "pending"
=> "is_published": false
, but for post-moderation, either "reviews_state": "pending"
or "accepted"
=> "is_published": true
). I'm not sure if we can fully ignore the reviews_state
flag here though, as we shouldn't be allowing a new version for "pre-moderation and rejected" and "pre-moderation and pending moderator approval", right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, as discussed, let's rely on date_published
instead of is_published
. There will be a BE fix to make sure is_latest_version
checks date_published
instead of is_published
.
Turns out it was the citations mirage endpoint failing! |
5515ddc
into
CenterForOpenScience:feature/preprints-doi-versioning
Todo
Purpose
Summary of Changes
canCreateNewVersion
attr to preprint modelScreenshot(s)
Accepted
Rejected (for pre-moderation providers)
Withdrawn
Side Effects
QA Notes