Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use source schema to find time column instead of projected schema #16

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

jiacai2050
Copy link
Member

@jiacai2050 jiacai2050 commented Mar 5, 2024

See apache/horaedb#1445

Projected schema may not contain all column used in query, such as:

select a from table where b > 1;

Only a is in projected schema.

Copy link
Member

@Rachelint Rachelint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rachelint Rachelint merged commit 05a8a9f into main Mar 5, 2024
1 check passed
Rachelint pushed a commit to apache/horaedb that referenced this pull request Mar 6, 2024
## Rationale
When time column is not in `select`, `extract_time_range` will not find
time range of one query

## Detailed Changes
- CeresDB/influxql#16

## Test Plan
CI
zealchen pushed a commit to zealchen/incubator-horaedb that referenced this pull request Apr 9, 2024
## Rationale
When time column is not in `select`, `extract_time_range` will not find
time range of one query

## Detailed Changes
- CeresDB/influxql#16

## Test Plan
CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants