Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-308: Documentation for conf file #134
DOC-308: Documentation for conf file #134
Changes from 8 commits
18b68cc
01f8528
0678a26
f125ae2
87400d1
fcf769f
6452ca4
b5b14ee
10fd1b7
e1de9f5
4c96266
0d227af
ddb1e16
b1e2f30
c6a496a
d4e29b1
48179a2
378125f
b2c2c5c
8c698c2
ebc0af8
0a661f3
228ddac
6703df4
5deca4a
5a6310f
ce4fcd9
9c9fe3e
a16014d
64c8cb2
35090a6
b8721a5
a4d1e99
86624af
eabbcec
7a170f3
8acdd86
8b38c09
055b3dc
45bcdf3
64fedaa
3d91b32
eb99063
8c7e90d
ca6e80c
d810aeb
e944fda
82b0b58
ff2bbe9
177cf9e
21bceee
05678f3
eacc988
f7ac815
4fce2ca
b326d35
8797697
37b8ebe
06eac96
286a0b1
45c3d9e
15b7d34
5e56ec2
93aca46
7d58aae
f53c9aa
6185a92
a5bc9ff
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be consistent with the other sections above (i.e. bullets).
Also, avoid manual formatting (like
**
) in favor of section headers (like###
).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do I know whether a flag is a map?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
listed the 2 map flags --solc_map and --solc_optimize_map
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "Objects" should be lowercase. Also, I wouldn't bold here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would break this into several lines - the generated page is hard to read because you have to scroll.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done