-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC-349] Updated documentation including links to examples #156
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments. Please also check that the CI is passing (looks like there is a typo), and add the link to the generated documentation to the PR comment (see the instructions in the default PR comment template).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another round of comments.
I think the biggest thing is that some of the examples need some context - see my comment on defs.md
for an example of what I mean.
For the examples that we expect to describe fully in the user guide (like the ERC20 examples linked to for rules, assert, and require statements), I wonder if it might be better to put a placeholder outline in the "Spec by Example" section of the user guide and move the example links there. Maybe it should be a separate PR though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall good, a few comments and requests to do a bit more cleaning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a bunch of the links got broken so I can't view the generated documentation. Can you fix them and re-request review?
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looking good, here's another round of edits.
Link to generated documentation