Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC-350] v5 change guide #172

Merged
merged 15 commits into from
Nov 16, 2023
Merged

[DOC-350] v5 change guide #172

merged 15 commits into from
Nov 16, 2023

Conversation

mdgeorge4153
Copy link
Contributor

@mdgeorge4153 mdgeorge4153 commented Nov 10, 2023

@mdgeorge4153 mdgeorge4153 added the future documentation for features that haven't landed yet label Nov 10, 2023
Copy link
Contributor

@shellygr shellygr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! one correction to be double checked

docs/cvl/v5-changes.md Outdated Show resolved Hide resolved
@shellygr
Copy link
Contributor

shellygr commented Nov 11, 2023

I also forgot about @steve-certora 's recent change disallowing solidity calls within quantifier bodies without a matching typechecker arg, which is also a breaking change. Steve can you help with a PR on this change specifically?

rahav-certora and others added 9 commits November 14, 2023 17:11
* DOC-350: Add CERT-926 docs to the v5 changes doc set.

* DOC-350: Tweak text and add emphasis lines in code for CERT-926 changes.

* DOC-350: Fix Pygments text lexer type for error message text.

* DOC-350: Emphasize-lines requires a code-block decoration, (maybe?).

* DOC-350: Remove backticks and change error comment per PR.

* DOC-350: Changes and updates suggested in PR.

- Clarifies language by removing direct references to Solidity.
- Provides better examples of ways to work around using contract
  method calls in quantified expression bodies.
- Document the command-line argument
  --allow_solidity_calls_in_quantifiers.

* DOC-350: Fix typo.

* DOC-350: Attempt to fix undefined label message for --allow_solidity...
@shellygr shellygr marked this pull request as ready for review November 16, 2023 16:37
@shellygr shellygr requested a review from a team as a code owner November 16, 2023 16:37
@shellygr shellygr merged commit be3874e into master Nov 16, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
future documentation for features that haven't landed yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants