-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC-350] v5 change guide #172
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shellygr
reviewed
Nov 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! one correction to be double checked
I also forgot about @steve-certora 's recent change disallowing solidity calls within quantifier bodies without a matching typechecker arg, which is also a breaking change. Steve can you help with a PR on this change specifically? |
* DOC-350: Add CERT-926 docs to the v5 changes doc set. * DOC-350: Tweak text and add emphasis lines in code for CERT-926 changes. * DOC-350: Fix Pygments text lexer type for error message text. * DOC-350: Emphasize-lines requires a code-block decoration, (maybe?). * DOC-350: Remove backticks and change error comment per PR. * DOC-350: Changes and updates suggested in PR. - Clarifies language by removing direct references to Solidity. - Provides better examples of ways to work around using contract method calls in quantified expression bodies. - Document the command-line argument --allow_solidity_calls_in_quantifiers. * DOC-350: Fix typo. * DOC-350: Attempt to fix undefined label message for --allow_solidity...
shellygr
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to generated documentation