Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V5 changelog #174

Merged
merged 18 commits into from
Nov 22, 2023
Merged

V5 changelog #174

merged 18 commits into from
Nov 22, 2023

Conversation

shellygr
Copy link
Contributor

Naming convention:

  • PRs for features that are in design should have the "proposal" label
  • PRs for features that haven't landed yet should have the "future" label
  • PRs for upcoming releases should have the "release" label
  • PRs with new documentation for existing features should have the "existing feature" label

Before requesting review:

  • Make sure there is a ticket in the DOC board in Jira
  • Make sure CI is passing
    • Spell check failure may require adding backticks around code or updating spelling_wordlist.txt
    • See README.md for information about style and markdown syntax
    • If the CI Details link gives a 404, you need to log in to readthedocs.com
  • Add link to generated documentation here
    • you can find this by following the read the docs link from the CI check
  • Ask for help in #documentation

Jira ticket: TODO
Link to generated documentation: TODO

mdgeorge4153 and others added 16 commits November 10, 2023 15:26
@mdgeorge4153
draft v5 change guide
009a6de
@mdgeorge4153
finished a section
fa4c5fc
@mdgeorge4153
tweaks
ea3c427
@mdgeorge4153
Merge branch 'mike/delete-summaries' into mike/v5-breaking-changes
68ddc5c
@mdgeorge4153
linked to DELETE summaries
5be4d9b
@mdgeorge4153
Merge branch 'master' into mike/v5-breaking-changes
ee1118f
@rahav-certora
add CLI section
007541b
@rahav-certora
test
f1924b1
@rahav-certora
revert
9f75fed
@rahav-certora
contract to parametric_contract
80e7f5f
@rahav-certora
test
4b13073
@rahav-certora
rename
6149d09
@rahav-certora
clean
90f34f9
@steve-certora
DOC-350: Add CERT-926 docs to the v5 changes doc set. (#173)
e3a4bc7 
* DOC-350: Add CERT-926 docs to the v5 changes doc set.

* DOC-350: Tweak text and add emphasis lines in code for CERT-926 changes.

* DOC-350: Fix Pygments text lexer type for error message text.

* DOC-350: Emphasize-lines requires a code-block decoration, (maybe?).

* DOC-350: Remove backticks and change error comment per PR.

* DOC-350: Changes and updates suggested in PR.

- Clarifies language by removing direct references to Solidity.
- Provides better examples of ways to work around using contract
  method calls in quantified expression bodies.
- Document the command-line argument
  --allow_solidity_calls_in_quantifiers.

* DOC-350: Fix typo.

* DOC-350: Attempt to fix undefined label message for --allow_solidity...
@shellygr
cleanup
82a2042
@shellygr
v5 changelog
14a8f6f
@shellygr shellygr requested a review from a team as a code owner November 22, 2023 14:57
mdgeorge4153
mdgeorge4153 suggested changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@mdgeorge4153 mdgeorge4153 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits

docs/prover/cli/options.md Outdated Show resolved Hide resolved
docs/prover/changelog/prover_changelog.md Show resolved Hide resolved
docs/prover/changelog/prover_changelog.md Show resolved Hide resolved
docs/prover/changelog/prover_changelog.md Show resolved Hide resolved
@shellygr shellygr merged commit f82ac09 into master Nov 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdgeorge4153 mdgeorge4153 Awaiting requested review from mdgeorge4153

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shellygr @mdgeorge4153 @rahav-certora @steve-certora