setup, mock and rules for SafeMigration, SafeToL2Migration and SafeToL2Setup #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoenicke
requested changes
Aug 30, 2024
certora/conf/SafeMigration.conf
Outdated
| "optimistic_loop": true, | ||
| "process": "emv", | ||
| "prover_args": [ | ||
| " -smt_groundQuantifiers false" |
There was a problem hiding this comment.
Do we need the quantifier options? If not, we could just not set the prover args.
This also applies to the other conf files.
certora/conf/SafeMigration.conf
Outdated
| "loop_iter": "3", | ||
| "msg": "SafeMigration", | ||
| "optimistic_hashing": true, | ||
| "optimistic_loop": true, |
There was a problem hiding this comment.
We could try without optimistic_loop here. I think there are no loops or unbounded hashing, so if we can prove it without, it would be better.
This also applies to the other conf files.
certora/conf/SafeMigration.conf
Outdated
| "prover_args": [ | ||
| " -smt_groundQuantifiers false" | ||
| ], | ||
| "rule_sanity": "basic", |
There was a problem hiding this comment.
Can you try with advanced sanity? The basic sanity will not check if the functions always revert, because you call them with @withreverted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jhoenicke ,
Following our brainstorming session for different rules, I prepared the following setup and rules.
I also added run links at the top of each spec file.
Those include runs of all the rules (both with and without sanity basic).
All the rules pass successfully.
Please review and advise if any changes should be made.
Thank you.