Temporarily remove nvrtc and nvrtc-builtins from install

CesiumGS · Oct 2, 2023 · ea25a85 · ea25a85
1 parent a061ccc
commit ea25a85
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 20 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -603,21 +603,21 @@ install(
             COMPONENT library
             EXCLUDE_FROM_ALL)
 
-# Nothing links against nvrtc-builtins but if we don't include it we get a runtime crash.
-# Unfortunately this means we have to bypass CMake's dependency system and install it manually here.
-if(WIN32)
-    install(
-        FILES "${PROJECT_SOURCE_DIR}/extern/nvidia/_build/target-deps/cuda/cuda/bin/nvrtc-builtins64_118.dll"
-        DESTINATION "${KIT_EXTENSION_BIN_PATH}"
-        COMPONENT install)
-else()
-    install(
-        FILES "${PROJECT_SOURCE_DIR}/extern/nvidia/_build/target-deps/cuda/cuda/lib64/libnvrtc-builtins.so"
-              "${PROJECT_SOURCE_DIR}/extern/nvidia/_build/target-deps/cuda/cuda/lib64/libnvrtc-builtins.so.11.8"
-              "${PROJECT_SOURCE_DIR}/extern/nvidia/_build/target-deps/cuda/cuda/lib64/libnvrtc-builtins.so.11.8.89"
-        DESTINATION "${KIT_EXTENSION_BIN_PATH}"
-        COMPONENT install)
-endif()
+# # Nothing links against nvrtc-builtins but if we don't include it we get a runtime crash.
+# # Unfortunately this means we have to bypass CMake's dependency system and install it manually here.
+# if(WIN32)
+#     install(
+#         FILES "${PROJECT_SOURCE_DIR}/extern/nvidia/_build/target-deps/cuda/cuda/bin/nvrtc-builtins64_118.dll"
+#         DESTINATION "${KIT_EXTENSION_BIN_PATH}"
+#         COMPONENT install)
+# else()
+#     install(
+#         FILES "${PROJECT_SOURCE_DIR}/extern/nvidia/_build/target-deps/cuda/cuda/lib64/libnvrtc-builtins.so"
+#               "${PROJECT_SOURCE_DIR}/extern/nvidia/_build/target-deps/cuda/cuda/lib64/libnvrtc-builtins.so.11.8"
+#               "${PROJECT_SOURCE_DIR}/extern/nvidia/_build/target-deps/cuda/cuda/lib64/libnvrtc-builtins.so.11.8.89"
+#         DESTINATION "${KIT_EXTENSION_BIN_PATH}"
+#         COMPONENT install)
+# endif()
 
 install(
     TARGETS CesiumOmniversePythonBindings

diff --git a/exts/cesium.omniverse/config/extension.toml b/exts/cesium.omniverse/config/extension.toml
@@ -52,11 +52,11 @@ archiveDirs = ["vendor"]
 [[native.plugin]]
 path = "bin/cesium.omniverse.plugin"
 
-[[native.library]]
-"filter:platform"."windows-x86_64"."path" = "bin/${lib_prefix}nvrtc-builtins64_118${lib_ext}"
+# [[native.library]]
+# "filter:platform"."windows-x86_64"."path" = "bin/${lib_prefix}nvrtc-builtins64_118${lib_ext}"
 
-[[native.library]]
-"filter:platform"."linux-x86_64"."path" = "bin/${lib_prefix}nvrtc-builtins${lib_ext}"
+# [[native.library]]
+# "filter:platform"."linux-x86_64"."path" = "bin/${lib_prefix}nvrtc-builtins${lib_ext}"
 
 [settings]
 exts."cesium.omniverse".defaultAccessToken = ""

diff --git a/src/core/CMakeLists.txt b/src/core/CMakeLists.txt
@@ -88,7 +88,7 @@ setup_lib(
         omni_kit
         omni_ui
         cuda
-        nvrtc
+        # nvrtc
         pybind11
         python310
     ADDITIONAL_LIBRARIES