Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "integratedTerminal" in launch.json #603

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented Dec 28, 2023

Fixes an issue where omni.kit.pipapi doesn't work on a clean install when using VS Code's internal console.

To reproduce, delete C:\Users\Sean\AppData\Local\ov\data\Kit\cesium.omniverse.dev and launch Development App from VS Code. You'll get the error:

2023-12-28 20:09:20  [Error] [carb.scripting-python.plugin] OSError: [WinError 6] The handle is invalid
2023-12-28 20:09:20  [Error] [carb.scripting-python.plugin] 
2023-12-28 20:09:20  [Error] [carb.scripting-python.plugin] At:
2023-12-28 20:09:20  [Error] [carb.scripting-python.plugin]   c:\users\sean\code\cesium-omniverse-2\extern\nvidia\_build\target-deps\kit-sdk\python\lib\subprocess.py(1334): _make_inheritable
2023-12-28 20:09:20  [Error] [carb.scripting-python.plugin]   c:\users\sean\code\cesium-omniverse-2\extern\nvidia\_build\target-deps\kit-sdk\python\lib\subprocess.py(1287): _get_handles
2023-12-28 20:09:20  [Error] [carb.scripting-python.plugin]   c:\users\sean\code\cesium-omniverse-2\extern\nvidia\_build\target-deps\kit-sdk\python\lib\subprocess.py(837): __init__
2023-12-28 20:09:20  [Error] [carb.scripting-python.plugin]   c:/users/sean/code/cesium-omniverse-2/extern/nvidia/_build/target-deps/kit-sdk/exts/omni.kit.pipapi/omni/kit/pipapi/pipapi.py(176): call_pip
2023-12-28 20:09:20  [Error] [carb.scripting-python.plugin]   c:/users/sean/code/cesium-omniverse-2/extern/nvidia/_build/target-deps/kit-sdk/exts/omni.kit.pipapi/omni/kit/pipapi/pipapi.py(294): install
2023-12-28 20:09:20  [Error] [carb.scripting-python.plugin]   c:/users/sean/code/cesium-omniverse-2/extern/nvidia/_build/target-deps/kit-sdk/exts/omni.kit.pipapi/omni/kit/pipapi/pipapi.py(65): wrapper
2023-12-28 20:09:20  [Error] [carb.scripting-python.plugin]   c:/users/sean/code/cesium-omniverse-2/exts/cesium.omniverse/cesium/omniverse/install/wheel_installer.py(77): _perform_install
2023-12-28 20:09:20  [Error] [carb.scripting-python.plugin]   c:/users/sean/code/cesium-omniverse-2/exts/cesium.omniverse/cesium/omniverse/install/wheel_installer.py(59): install
2023-12-28 20:09:20  [Error] [carb.scripting-python.plugin]   c:/users/sean/code/cesium-omniverse-2/exts/cesium.powertools/cesium/powertools/extension.py(90): _install_py_dependencies
2023-12-28 20:09:20  [Error] [carb.scripting-python.plugin]   c:/users/sean/code/cesium-omniverse-2/exts/cesium.powertools/cesium/powertools/extension.py(21): __init__
2023-12-28 20:09:20  [Error] [carb.scripting-python.plugin]   c:\users/sean/code/cesium-omniverse-2/extern/nvidia/_build/target-deps/kit-sdk/kernel/py\omni\ext\_impl\_internal.py(158): _startup_ext
2023-12-28 20:09:20  [Error] [carb.scripting-python.plugin]   c:\users/sean/code/cesium-omniverse-2/extern/nvidia/_build/target-deps/kit-sdk/kernel/py\carb\profiler\__init__.py(85): wrapper
2023-12-28 20:09:20  [Error] [carb.scripting-python.plugin]   c:\users/sean/code/cesium-omniverse-2/extern/nvidia/_build/target-deps/kit-sdk/kernel/py\omni\ext\_impl\_internal.py(224): startup
2023-12-28 20:09:20  [Error] [carb.scripting-python.plugin]   c:\users/sean/code/cesium-omniverse-2/extern/nvidia/_build/target-deps/kit-sdk/kernel/py\omni\ext\_impl\_internal.py(328): startup_extension
2023-12-28 20:09:20  [Error] [carb.scripting-python.plugin]   PythonExtension.cpp::startup()(2): <module>
2023-12-28 20:09:20  [Error] [carb.scripting-python.plugin] 
2023-12-28 20:09:20  [Error] [omni.ext.plugin] [ext: cesium.powertools-0.1.0] Failed to startup python extension.

Previously this was fixed by switching to the external terminal #371 but this was reverted in #478 because it was annoying to close external terminals. The original problem still exists though, and switching to "console": "integratedTerminal" seems to fix it.

@lilleyse lilleyse changed the title Use VSCode integrated terminal in launch.json Use "integratedTerminal" in launch.json Dec 28, 2023
@lilleyse lilleyse enabled auto-merge December 29, 2023 15:54
Copy link
Contributor

@r-veenstra r-veenstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested here, reproduced and now working as expected.

@lilleyse lilleyse merged commit a7c1733 into main Jan 2, 2024
3 checks passed
@lilleyse lilleyse deleted the integrated-terminal branch January 2, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants