-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAIP-300: Wallet Connect JSON-RPC Method #300
base: main
Are you sure you want to change the base?
Conversation
{ | ||
"method": "wallet_grantPermissions", // ERC-7715 request | ||
"params": {...} | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this standard allow for personal_sign
to be sent via wallet_connect
? As at the time of requesting it, the user address is unknown to the dapp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really... you need to use wallet_authenticate
How will the standard handle the request if one of the rpc method requested via |
Then the wallet must reject it with 7001 code for invalid method Or partially reject it with an error message in the batch |
Can we consider adding
|
@lukaisailovic i'm seeing a commit adding jake as author but not one adding a _disconnect method (or for that matter, pointing to the _disconnect method added by the still-open CAIP-285 PR) 😅 holler at me when there's an approval from jake so we can get this merged and visible on the website 😎 |
@jxom there is only one concern with introducing wallet_disconnect here... the different payloads have different purposes So is the intention to batch them together as a batch "disconnection"... for example you have wallet_authenticate and wallet_createSession... the former is providing a SIWE signature while the latter is enabling a live session with the wallet... are you disconnecting both?? Also regarding ERC-7715 would the wallet_disconnect perform a wallet_revokePermissions?? Definitely agree that the absence of |
Co-authored-by: Bumblefudge <[email protected]>
i've lost the plot a bit, what are next steps here, @pedrouid ? this looks complete but I vaguely remember this being blocked on some of the non-DOM connection flows or something? Totally fine to switch it to draft if you're waiting for other implementers or open research questions to finish it. |
This CAIP defines a JSON-RPC method to request a batch of RPC methods to be resolved when connecting a wallet in a single roundtrip.